patchGnash - The GNU Flash player - Patches: patch #8851, Patch to make `GetVariable()`...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8851: Patch to make `GetVariable()` plugin function use SWF version-specific string conversion

Submitted by:  Nutchanon Wetchasit <nachanon>
Submitted on:  Mon 11 Jan 2016 03:00:28 PM UTC  
 
Category: corePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sandro Santilli <strk>Open/Closed: Closed

Tue 12 Jan 2016 12:59:06 PM UTC, comment #1:

Pushed as commit 6671ff0f7c0c9d35d4432001a64f2c132f70158f

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 11 Jan 2016 03:00:28 PM UTC, original submission:

Currently, Gnash's implementation of `GetVariable()` plugin interface uses
variable-to-string conversion function that is based on SWF7 convention
which causes discrepancy when the variable in question has `undefined` value
and root SWF is version 6 or below (it gives a string "undefined" instead of
the expected empty string).

This patch makes it use a correct string conversion convention according to
root movie's SWF version, and adjusts the relevant automated test accordingly;
fixing bug #46719, unblocking automated check of bug #45840 under SWF5.

See the attached `0001_getvariable-use-correct-string-conversion.patch`.

Gnash: 0.8.11dev (patched against git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

Attached Files
file #35991:  0001_getvariable-use-correct-string-conversion.patch added by nachanon (3KiB - text/x-patch - Patch to make `GetVariable()` plugin function use SWF version-specific string conversion)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by nachanon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 12 Jan 2016 12:59:06 PM UTCstrkStatusIn Progress=>Done
      Open/ClosedOpen=>Closed
    Tue 12 Jan 2016 12:28:01 PM UTCstrkStatusNone=>In Progress
      Assigned toNone=>strk
    Mon 11 Jan 2016 03:00:28 PM UTCnachanonAttached File-=>Added 0001_getvariable-use-correct-string-conversion.patch, #35991

    Back to the top


    Powered by Savane 3.1-cleanup1