patchGnash - The GNU Flash player - Patches: patch #8851, Patch to make `GetVariable()`...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8851: Patch to make `GetVariable()` plugin function use SWF version-specific string conversion

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Mon 11 Jan 2016 03:00:28 PM UTC
   
 
Category:  core Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Tue 12 Jan 2016 12:59:06 PM UTC, comment #1: 

Pushed as commit 6671ff0f7c0c9d35d4432001a64f2c132f70158f

 Sandro Santilli <strk>
Group Member
Mon 11 Jan 2016 03:00:28 PM UTC, original submission:  

Currently, Gnash's implementation of `GetVariable()` plugin interface uses
variable-to-string conversion function that is based on SWF7 convention
which causes discrepancy when the variable in question has `undefined` value
and root SWF is version 6 or below (it gives a string "undefined" instead of
the expected empty string).

This patch makes it use a correct string conversion convention according to
root movie's SWF version, and adjusts the relevant automated test accordingly;
fixing bug #46719, unblocking automated check of bug #45840 under SWF5.

See the attached `0001_getvariable-use-correct-string-conversion.patch`.

Gnash: 0.8.11dev (patched against git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

 Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #35991:  0001_getvariable-use-correct-string-conversion.patch added by nachanon (3KiB - text/x-patch - Patch to make `GetVariable()` plugin function use SWF version-specific string conversion)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Updated the item)
  • -email is unavailable- added by nachanon (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-01-12 strk StatusIn Progress Done
        Open/ClosedOpen Closed
    2016-01-12 strk StatusNone In Progress
        Assigned toNone strk
    2016-01-11 nachanon Attached File- Added 0001_getvariable-use-correct-string-conversion.patch, #35991

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-5190.
    Corresponding source code