patchgrep - Patches: patch #883, patch to color filenames in grep...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #883: patch to color filenames in grep output

Submitter:  Invalid User ID <#14041>
Submitted:  Mon 23 Dec 2002 04:04:27 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Duplicate Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Wed 26 Jan 2005 02:55:10 PM UTC, comment #5: 

OK, I closed this patch.
Obsoleted by patch #3644.

Stepan Kasal <kasal>
Group Member
Sat 15 Jan 2005 02:11:17 AM UTC, comment #4: 


I meant GREP_COLORS, not DIR_COLORS.


Charles Levert <charles_levert>
Sat 15 Jan 2005 02:08:51 AM UTC, comment #3: 


I have implemented DIR_COLORS (plural) in
patch #3644 so it now completely obsoletes
and is a strict functional superset of this
one.


Charles Levert <charles_levert>
Fri 14 Jan 2005 09:32:38 PM UTC, comment #2: 


I have submitted a new patch that does additional
colorizing more extensively (patch #3644).

Already, not only can lines of content be
prepended with the filename (-H), they can also
be with the line number (-n) and the octet
offset (-b).  When context is used, groups of
lines can be separated with "--" on a single
line (which can be mistaken for content when
nothing is prepended as with -3h).

Moreover, with an additional new feature (-T or
--initial-tab), whitespace can be inserted
between a prepended item and its separator (";"
or "-").

All this highlights the fact that separators
should not be treated as being part of the
prepended item they follow, and so that they
merit their own color.

The new patch implements all this, but it
purposely leaves out a mechanism for user
configuration, for now.  The approach for
this that is used in this patch #883, adding
one variable per new colorizable item, is
one option, but it can make for many variables.
Another solution to be considered would be to
reuse the single variable GREP_COLOR in a
backward compatible way so that it both supports
just the string for matches, and a new full
specification similar to what is done with
LS_COLORS (see dircolors(1)).  This is up for
careful evaluation.


Charles Levert <charles_levert>
Fri 15 Aug 2003 09:29:45 AM UTC, comment #1: 

Duh! Sorry about that: my last comment should apply to a different patch.

Anonymous
Mon 23 Dec 2002 04:04:27 PM UTC, original submission:  

I haven't been able to create a savannah account, but my email address is in the patch; feel free to contact me that way.

I've run "make check", and there's a single failure (spencer test 55), but that seems to fail with unmodified grep 2.5.1 anyway.

 --elliott

Invalid User ID <#14041>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-01-26 kasal StatusNone Duplicate
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-4448.
Corresponding source code