patchGnash - The GNU Flash player - Patches: patch #8758, Patch to add newlines to Gnash...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8758: Patch to add newlines to Gnash player-to-plugin return value messages

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Mon 05 Oct 2015 07:12:49 AM UTC
   
 
Category:  core Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Tue 15 Dec 2015 07:23:14 AM UTC, comment #1: 

std::endl is to be preferred, I'd say.
Why not adding it only once right before the "write" call (I'm looking at movie_root.cpp) rather than in each and every case ?

Anyway, I pushed the patch with:
commit 45b945d35e701cca19b3e393ca51ce0d12b4691b

So to unblock other work.

Sandro Santilli <strk>
Group Member
Mon 05 Oct 2015 07:12:49 AM UTC, original submission:  

Currently, Gnash does not always terminate message sent to host container via
`-F`/`--fd` pipe with '\n', which can causes difficulty in writing a line-based
container-emulation automated test.

The patch adds newline to every return value-related message that Gnash
sends to host container:


which fixes bug #46115.
This should not have any affect on NPAPI libgnashplugin's normal operation.

Note: It might need a bit of review, since there're two way to implement this,
one is using `std::endl` with `std::stringstream` (which is used by
`ExternalInterface.makeInvoke()`), another way is using bare '\n'.
The patch uses the former.

Gnash: Gnash 0.8.11dev (patched against git f0f66ce 23-Sep-2015) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #35065:  0001_add-newline-externalinterface-pluginfunc-return.patch added by nachanon (3KiB - text/x-patch - Patch to add newlines to Gnash player-to-plugin return value messages)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-15 strk StatusNone Done
        Assigned toNone strk
        Open/ClosedOpen Closed
    2015-10-05 nachanon Attached File- Added 0001_add-newline-externalinterface-pluginfunc-return.patch, #35065

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-72d9.
    Corresponding source code