patchGnash - The GNU Flash player - Patches: patch #8753, Patch to make `./configure` be...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8753: Patch to make `./configure` be descriptive on how Gnash uses Csound

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Sat 26 Sep 2015 08:24:04 AM UTC
   
 
Category:  build Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Sat 26 Dec 2015 02:38:16 PM UTC, comment #2: 

Applied with slightly modified message in commit 15d61a804138737764689338c491c41f2cf59acf

Thanks.

Sandro Santilli <strk>
Group Member
Sat 26 Sep 2015 08:39:41 AM UTC, comment #1: 

If I recall correctly, csound is not really needed to generate test files because those files (generated) are included even in the git repository. It's to be checked.

I'd be ok to only rely on csound for generating them, if someone has enough fun to build a robust set of sound-checking tests (by robust I mean that those generated files are not different based on csound version).

Sandro Santilli <strk>
Group Member
Sat 26 Sep 2015 08:24:04 AM UTC, original submission:  

With current version of Gnash, when user tried to run `./configure` script
without Csound tools installed on the system, it would show a following message:

        WARNING: You need to have csound installed
                 to have real fun.
                 Install it from http://www.csounds.com/
                 or .deb users: apt-get install csound
                 or .rpm users: yum install csound


Instead of "to have real fun", the message should show what exactly Csound
have to do with Gnash's build process or testing process; allowing user
to make an informed decision whether to install it or not.

In this case, according to `testsuite/media/Makefile.am`, Csound is used
for generating some audio files for Gnash's audio-related test cases.

Proposed patch changes the message to:

        WARNING: You need to have csound installed to generate some of
                 sound-related test files in Gnash testsuite.
                 Install it from http://www.csounds.com/
                 or .deb users: apt-get install csound
                 or .rpm users: yum install csound


Note: this patch uses `PKG_WAR()`, `PKG_SUGGEST()`, `DEB_INSTALL()`,
and `RPM_INSTALL()` macro facility instead of printing directly to fd 4.

Gnash: 0.8.11dev (patched against git f0f66ce 23-Sep-2015)
CSound: libcsound64-5.2 1:5.17.11~dfsg-3 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #34981:  0001_rewrite-configure-csound-message.patch added by nachanon (947B - text/x-patch - Patch for improving `./configure` message on missing Csound tools)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-26 strk StatusNone Done
        Assigned toNone strk
        Open/ClosedOpen Closed
    2015-09-26 nachanon Attached File- Added 0001_rewrite-configure-csound-message.patch, #34981

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code