patchGnash - The GNU Flash player - Patches: patch #8752, Patch to allow `-v` command line...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8752: Patch to allow `-v` command line switches to override non-zero logging verbosity specified in `.gnashrc`

Submitted by:  Nutchanon Wetchasit <nachanon>
Submitted on:  Wed 23 Sep 2015 02:20:50 PM UTC  
 
Category: guiPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sandro Santilli <strk>Open/Closed: Closed

Wed 23 Sep 2015 02:24:41 PM UTC, comment #1:

Pushed, thanks.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 23 Sep 2015 02:20:50 PM UTC, original submission:

See the attached `0001_allow-command-line-to-override-log-verbosity.patch`.

Currently, if user set logging verbosity in Gnash's Edit > Preferences dialog
(or in `~/.gnashrc`) to non-zero value, Gnash ignores `-v` option specified
on the command line.

The patch make Gnash always use verbosity level set from command line first
if `-v` option(s) are specified, and fall back to configuration file or default
if they are not; partially fixing bug #40487.

This is done by changing the logic used in `Player.init_logfile()`
to check whether the verbosity is already set to non-zero value
before considering verbosity value specified in configuration file;
if so, ignore the value from configuration file; if not, load the value
from configuration file.

Note: This patch does not provide provision for overriding verbosity to zero,
and does not change the way Edit > Preferences dialog works.
(It still only displaying and saving verbosity from/to configuration file)

Gnash: 0.8.11dev (patched against git c0e274d 23-Sep-2015)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

Attached Files
file #34964:  0001_allow-command-line-to-override-log-verbosity.patch added by nachanon (768B - text/x-patch - Patch to allow command line switch to override configuration file-specified verbosity)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by nachanon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Sep 2015 02:24:41 PM UTCstrkStatusNone=>Done
      Assigned toNone=>strk
      Open/ClosedOpen=>Closed
    Wed 23 Sep 2015 02:20:50 PM UTCnachanonAttached File-=>Added 0001_allow-command-line-to-override-log-verbosity.patch, #34964

    Back to the top


    Powered by Savane 3.1-cleanup1