patchGnash - The GNU Flash player - Patches: patch #8738, Patch to correct audio data size...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8738: Patch to correct audio data size in 8 to 16-bit embeded PCM sound conversion (GStreamer backend)

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Sun 13 Sep 2015 01:30:27 PM UTC
   
 
Category:  sound Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Mon 14 Sep 2015 08:43:12 AM UTC, comment #3: 

Thanks, pushed as commits 76b8fa551a4c4849c72318e6fb7bcafb070485db and c16e78cd22f2fb2c656c378399aba0d3956e5254

Sandro Santilli <strk>
Group Member
Mon 14 Sep 2015 07:47:28 AM UTC, comment #2: 

Patch 2: see the attached `0003_use-correct-raw-audio-block-size-after-16bit-conversion.patch`.

I have tested and found that the bug affects decoding of 8-bit sterero
RAW PCM sound in the same way. So this additional patch fixes the same issue
within RAW PCM decoder.

Gnash: 0.8.11dev (patched against git f5016cc 9-Sep-2015)
SDL: libsdl1.2debian 1.2.15-5 (debian)
GStreamer: libgstreamer0.10-0 0.10.36-1.2 (debian)
CSound: libcsound64-5.2 1:5.17.11~dfsg-3 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

(file #34873)

Nutchanon Wetchasit <nachanon>
Sun 13 Sep 2015 01:38:03 PM UTC, comment #1: 

The "Original code used `4`" phrase in previous post was misquoted, sorry.
The real line number should be 404:
http://git.savannah.gnu.org/cgit/gnash.git/tree/libmedia/AudioDecoderSimple.cpp?id=f5016cc9399c9ffd3c5d32c67bb28fac285559c6#n404

Though this issue might apply to `RAW` codec too.
(The fix covers only `UNCOMPRESSED` codec)

Nutchanon Wetchasit <nachanon>
Sun 13 Sep 2015 01:30:27 PM UTC, original submission:  

Currently Gnash (GStreamer media handler) has a problem on playing
8-bit stereo PCM embeded sound. This was due to wrong output size
was given out by the decoder when the sound is stereo.

This patch fixes this issue by correcting the buffer size multiplier used
when the decoder converts 8-bit to 16-bit PCM, which is supposed to be `2`.
(Original code used `4` if the sound is stereo, which it shouldn't, since
stereo expansion and further size multiplication, are done separately).

See the attached `0002_use-correct-audio-block-size-after-16bit-conversion.patch`.

Note: This fix does not cover FFmpeg/libAV media handler.

Gnash: 0.8.11dev (patched against git f5016cc 9-Sep-2015)
SDL: libsdl1.2debian 1.2.15-5 (debian)
GStreamer: libgstreamer0.10-0 0.10.36-1.2 (debian)
CSound: libcsound64-5.2 1:5.17.11~dfsg-3 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #34873:  0003_use-correct-raw-audio-block-size-after-16bit-conversion.patch added by nachanon (698B - text/x-patch - Patch to correct audio block size multiplier in 8 to 16-bit embeded RAW PCM sound conversion)
file #34869:  0002_use-correct-audio-block-size-after-16bit-conversion.patch added by nachanon (703B - text/x-patch - Patch to correct audio block size multiplier in 8 to 16-bit embeded PCM sound conversion)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-14 strk StatusNone Done
        Assigned toNone strk
        Open/ClosedOpen Closed
    2015-09-14 nachanon Attached File- Added 0003_use-correct-raw-audio-block-size-after-16bit-conversion.patch, #34873
    2015-09-13 nachanon Attached File- Added 0002_use-correct-audio-block-size-after-16bit-conversion.patch, #34869

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code