Gnash - The GNU Flash player - Patches: patch #8734, Patches for improving...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8734: Patches for improving `--audio-dump` support in Gnash
Submitter: | Nutchanon Wetchasit <nachanon> | ||
Submitted: | Mon 07 Sep 2015 09:31:43 AM UTC | ||
Category: | sound | Priority: | 5 - Normal |
Status: | In Progress | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Open |
Jump to the original submission
Thu 26 Jan 2017 11:03:54 AM UTC, comment #10: |
Sandro Santilli <strk>![]() ![]() |
Thu 01 Oct 2015 04:52:06 PM UTC, comment #9: Patch 4 of 4: see the attached `0004_use-endian-neutral-wave-header-write.patch`
|
Nutchanon Wetchasit <nachanon> |
Wed 09 Sep 2015 11:48:22 AM UTC, comment #8: I think the output message was meant to be used by shell scripts, notice the comment in first line and the variable set in second line |
Sandro Santilli <strk>![]() ![]() |
Wed 09 Sep 2015 11:25:44 AM UTC, comment #7: Patch 3: see the attached `0003_fix-audio-dump-message.patch`
|
Nutchanon Wetchasit <nachanon> |
Tue 08 Sep 2015 08:12:52 PM UTC, comment #6: I've changed the comment as described below in c969f9d9d9a. |
Bastiaan Jacques <bjacques>![]() |
Mon 07 Sep 2015 07:30:37 PM UTC, comment #5: both patches pushed to master |
Sandro Santilli <strk>![]() ![]() |
Mon 07 Sep 2015 07:17:21 PM UTC, comment #4: actually, don't bother, I'm building and will push as soon as quickly tested. |
Sandro Santilli <strk>![]() ![]() |
Mon 07 Sep 2015 07:14:23 PM UTC, comment #3: Can you go ahead and commit them Bastiaan ? Or I'll try to find the time myself ... |
Sandro Santilli <strk>![]() ![]() |
Mon 07 Sep 2015 06:25:11 PM UTC, comment #2:
|
Bastiaan Jacques <bjacques>![]() |
Mon 07 Sep 2015 11:11:57 AM UTC, comment #1: Patch 2 of 4: see the attahced `0002_flush-wave-metadata-on-audio-dump-end.patch`.
|
Nutchanon Wetchasit <nachanon> |
Mon 07 Sep 2015 09:31:43 AM UTC, original submission:
Gnash's support for `--audio-dump`/`-A` option have some problems that
|
Nutchanon Wetchasit <nachanon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 10 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-10-01 | nachanon | Attached File | - | ![]() |
Added 0004_use-endian-neutral-wave-header-write.patch, #35023 |
2015-09-09 | nachanon | Attached File | - | ![]() |
Added 0003_fix-audio-dump-message.patch, #34839 |
2015-09-08 | bjacques | Status | Done | ![]() |
In Progress |
Open/Closed | Closed | ![]() |
Open | ||
2015-09-07 | strk | Status | In Progress | ![]() |
Done |
Open/Closed | Open | ![]() |
Closed | ||
2015-09-07 | strk | Status | None | ![]() |
In Progress |
Assigned to | None | ![]() |
strk | ||
2015-09-07 | nachanon | Attached File | - | ![]() |
Added 0002_flush-wave-metadata-on-audio-dump-end.patch, #34824 |
2015-09-07 | nachanon | Attached File | - | ![]() |
Added 0001_use-correct-riff-wave-chunk-size.patch, #34823 |
Patch 4/4 applied with git.savannah.gnu.org/cgit/gnash.git/commit/?id=f9db2f227e72b177854f497b72c0f9ab45b6869a
The output message change included in Patch 3/4 (pushed with git.savannah.gnu.org/cgit/gnash.git/commit/?id=2f7d9b270b6ae90ef1af5ceb4ad6a49d5a053c04) should probably still be reverted to avoid breaking scripted usages of dump-gnash, which would use the output as a shell script setting variables (AUDIOFILE=xxxx; # comment).