patchClasspath Extensions - Patches: patch #8294, gnu.inet.util.CRLFOutputStream add...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8294: gnu.inet.util.CRLFOutputStream add beginning of line field: atBOL

Submitted by:  Conrad T. Pino <conradpino>
Submitted on:  Tue 28 Jan 2014 07:15:54 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Conrad T. Pino <conradpino> Open/Closed:  Open

Tue 28 Jan 2014 11:20:41 PM UTC, comment #3:

svn ci -m "patch #8294: gnu.inet.util.CRLFOutputStream add beginning of line field: atBOL" trunk/inetlib

Committed revision 1239.

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.
Tue 28 Jan 2014 11:10:57 PM UTC, comment #2:

Prior patch was incomplete; it failed to reset atBOL to false when method "public void write(byte[] b, int off, int len)" buffer did not end with newline sequence.

Issues second patch addresses are:

1. Remove white space between method name and "(" character.

2. Optimize duplicated "len - d" with "len -= d" and "len".

3. Correct atBOL reset omission.

(file #30399)

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.
Tue 28 Jan 2014 07:44:13 PM UTC, comment #1:

svn ci -m "patch #8294: gnu.inet.util.CRLFOutputStream add beginning of line field: atBOL" trunk/inetlib

Committed revision 1237.

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.
Tue 28 Jan 2014 07:15:54 PM UTC, original submission:

1. Add "protected boolean atBOL;" field.

2. Replace ASCII decimal (13, 10) with character ('\r', '\n') constants.

3. Replace if else if else ladder with switch statement.

4. Replace all "out.write(CRLF...)" with "writeln()" statement.

5. Replace decimal constant "2" with "CRLF.length" value.

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.

 

Attached Files
file #30399:  CRLFOutputStream.patch added by conradpino (977B - application/octet-stream - Supplemental patch; prior file required as well.)
file #30396:  CRLFOutputStream.patch added by conradpino (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by conradpino (Submitted the item)
  • -email is unavailable- added by conradpino
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-28 conradpino StatusIn Progress => Done
    2014-01-28 conradpino Attached File- => Added CRLFOutputStream.patch, #30399
        StatusDone => In Progress
    2014-01-28 conradpino StatusIn Progress => Done
    2014-01-28 conradpino Attached File- => Added CRLFOutputStream.patch, #30396
        Carbon-Copy- => Added dog

    Back to the top


    Powered by Savane 3.3