patchGnash - The GNU Flash player - Patches: patch #8226, fix cppcheck "Ineffective...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8226: fix cppcheck "Ineffective call" report

Submitter:  Julien Nabet <julien2412>
Submitted:  Tue 29 Oct 2013 10:32:24 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Thu 31 Oct 2013 07:17:31 PM UTC, comment #1: 
Sandro Santilli <strk>
Group Member
Tue 29 Oct 2013 10:32:24 PM UTC, original submission:  

Hello,

Cppcheck reported this:
[gui/qt/Qt4Gui.cpp:510]: (warning) Ineffective call of function 'empty()'. Did you intend to call 'clear()' instead?
Indeed, we've got this:
    507         if (newDepth == 0) {
    508             // Insert top level entries directly into the tree widget.
    509             items.append(item);
    510             stack.empty();
    511         } else {

I attached a straightforward patch.

Julien

Julien Nabet <julien2412>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #29503:  Qt4Gui_patch.txt added by julien2412 (480B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Updated the item)
  • -email is unavailable- added by julien2412 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-10-31 strk StatusIn Progress Done
        Open/ClosedOpen Closed
    2013-10-31 strk StatusNone In Progress
        Assigned toNone strk
    2013-10-29 julien2412 Attached File- Added Qt4Gui_patch.txt, #29503

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code