patchGnash - The GNU Flash player - Patches: patch #8225, fix cppcheck reports for...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #8225: fix cppcheck reports for memtest.cpp

Submitted by:  Julien Nabet <julien2412>
Submitted on:  Tue 29 Oct 2013 07:23:13 PM UTC  
 
Category: testsuitePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: Rob Savoye <rsavoye>Open/Closed: Open

Thu 31 Oct 2013 08:33:48 PM UTC, comment #1:

The memtest.cpp is not built by default. It seems to be a test for Memory class, which is only used by cygnal. Will leave this to Rob to look at.

Sandro Santilli <strk>
Project Member
Tue 29 Oct 2013 07:23:13 PM UTC, original submission:

Hello,

On git gnash sources retrieved today, cppcheck reported this:
[testsuite/libbase.all/memtest.cpp:53]: (style) Variable 'diff' is assigned a value that is never used.
[testsuite/libbase.all/memtest.cpp:98]: (style) Variable 'x' is allocated memory that is never used.
[testsuite/libbase.all/memtest.cpp:80]: (warning) Logical disjunction always evaluates to true: diff >= 8 || diff <= 16.

I attached a patch for fixing them.

Julien

Julien Nabet <julien2412>

 

Attached Files
file #29502:  memtest_patch.cpp added by julien2412 (1kB - text/x-c++src)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by julien2412 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 31 Oct 2013 08:33:48 PM UTCstrkAssigned toNone=>rsavoye
    Tue 29 Oct 2013 07:23:13 PM UTCjulien2412Attached File-=>Added memtest_patch.cpp, #29502

    Back to the top


    Powered by Savane 3.1-cleanup