patchGnash - The GNU Flash player - Patches: patch #8167, ffmpeg handler can't play AAC...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #8167: ffmpeg handler can't play AAC (e.g. youtube)

Submitted by:  Gabriele Giacone <gg0>
Submitted on:  Thu 22 Aug 2013 01:49:07 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Gabriele Giacone <gg0>Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Wed 04 Sep 2013 08:44:09 PM UTC, comment #7:

Thanks for reviewing

Gabriele Giacone <gg0>
Project MemberIn charge of this item.
Wed 04 Sep 2013 08:41:07 PM UTC, comment #6:

Gabriele, isn't this done ?

Sandro Santilli <strk>
Project Member
Fri 23 Aug 2013 03:02:18 PM UTC, comment #5:

avcodec version 53.25.0 can play AAC just fine.
This is the version installed on Ubuntu 12.04 and Debian Wheezy (stable)

This branch works fine for me, only problem is with the RECOMMENDED line which is needlessly recommending somehitng to me.

https://github.com/strk/gnash/tree/resample2

Sandro Santilli <strk>
Project Member
Thu 22 Aug 2013 10:14:10 AM UTC, comment #4:

there's a bug in your AudioResamplerFfmpeg::~AudioResamplerFfmpeg.
A {} block is missing, so avresample_free(&_context); is always called, even if _context is null

Could you fix this in your branch ?

Sandro Santilli <strk>
Project Member
Thu 22 Aug 2013 09:19:17 AM UTC, comment #3:

I think in absence of libswresample/libavresample the code should behave as before, that is (gg0 said) using the internal (limited) resampler. RECOMMENDED would be fine, with an indication of what would be missing by not following the recommandation.

Sandro Santilli <strk>
Project Member
Thu 22 Aug 2013 09:17:10 AM UTC, comment #2:

It is. All resampling conversions would be done by libswresample (ffmpeg) or libavresample (libav) dedicated libraries.

Gabriele Giacone <gg0>
Project MemberIn charge of this item.
Thu 22 Aug 2013 09:00:55 AM UTC, comment #1:

Does this patch introduce a new dependency ?
I'm now getting:

ERROR: No libswresample/libavresample development package installed!
You can install libswresample from http://ffmpeg.org
or .deb users: apt-get install libavresample-dev
or reconfigure with --enable-media=gst

Is that intentional ? (it used to build fine before)

Sandro Santilli <strk>
Project Member
Thu 22 Aug 2013 01:49:07 AM UTC, original submission:

As said at http://lists.gnu.org/archive/html/gnash-dev/2013-08/msg00002.html

available here https://github.com/gg0/gnash/commits/resample

Added minimum supported ffmpeg version (debian stable one) bump.

Gabriele Giacone <gg0>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by gg0 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 04 Sep 2013 08:44:09 PM UTCgg0StatusNone=>Done
      Assigned toNone=>gg0
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup