Gnash - The GNU Flash player - Patches: patch #8165, Fix warning: comparison of...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8165: Fix warning: comparison of unsigned expression >= 0 is always true
Submitter: | Gabriele Giacone <gg0> | ||
Submitted: | Mon 19 Aug 2013 06:47:32 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Thu 22 Aug 2013 08:35:51 AM UTC, comment #3: |
Sandro Santilli <strk> |
Thu 22 Aug 2013 07:35:42 AM UTC, comment #2: Oops, I just realized the code already has a MIN_PROBE_SIZE=0, well, in that case we should just drop the while block, as it would never run anyway |
Sandro Santilli <strk> |
Thu 22 Aug 2013 07:33:44 AM UTC, comment #1: Your patch turns a probing into a full scan. Better reviewed by Bastiaan as I haven't done GST much (more on the FFMPEG side).
|
Sandro Santilli <strk> |
Mon 19 Aug 2013 06:47:32 PM UTC, original submission:
Attached patch removes useless check.
|
Gabriele Giacone <gg0> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2013-08-22 | strk | Status | None | Done | |
Open/Closed | Open | Closed | |||
2013-08-19 | gg0 | Attached File | - | Added patch, #28877 |
Powered by Savane 3.13-4b48.
Corresponding source code
Whole probing code removed from GST MediaParser with this commit:
http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=9d14acb46f2b59b9dbdb96932e52e848b8500202