patchGNU Autoconf Archive - Patches: patch #7918, AX_CHECK_ZLIB() is no-op by...

 
 

patch #7918: AX_CHECK_ZLIB() is no-op by default (contrary to documentation)

Submitter:  None
Submitted:  Tue 08 Jan 2013 10:33:23 PM UTC
   
 
Priority:  5 - Normal Status:  Invalid
Assigned to:  simons Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 01 Feb 2013 03:35:31 PM UTC, comment #2: 

Hi,

Sorry, yeah, it has already been fixed.  I'm using the autoconf package in debian testing and didn't realize the bug was fixed upstream.  I received an e-mail from someone a while back letting me know this and assumed they had closed the ticket.  I can't close it myself.  If you can, please do so.

Kipp Cannon <kipp>
Fri 01 Feb 2013 11:10:12 AM UTC, comment #1: 

This patch does not apply to the version of AX_CHECK_ZLIB we have in the repository:


$ patch -p1 <ax_check_zlib_noop.patch
patching file ax_check_zlib.m4
Hunk #1 FAILED at 65.
Hunk #2 succeeded at 86 with fuzz 2 (offset 6 lines).
1 out of 2 hunks FAILED -- saving rejects to file ax_check_zlib.m4.rej


Could you please check whether the patch is still necessary in the current version of the macro and re-generate it properly if possible?

Peter Simons <simons>
Group administrator
Tue 08 Jan 2013 10:33:23 PM UTC, original submission:  

when the user gives neither --without-zlib nor --with-zlib=... on the configure command line, the AX_CHECK_ZLIB() macro is supposed to check for zlib in various default locations, however the macro simply prints the message "checking if zlib is wanted... yes" and does nothing else.  no checks for zlib are performed, and the HAVE_ZLIB variable is not set.

attached is a patch that fixes this.  there are many different ways to fix it depending on aesthetic preferences, this is just one suggestion.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27227:  ax_check_zlib_noop.patch added by None (745B - text/x-patch - patch to fix no-op behaviour in AX_CHECK_ZLIB())

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kipp (Posted a comment)
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-02-02 simons StatusNeed Info Invalid
        Open/ClosedOpen Closed
    2013-02-01 simons StatusNone Need Info
        Assigned toNone simons
    2013-01-08 None Attached File- Added ax_check_zlib_noop.patch, #27227

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code