LibreDWG - Patches: patch #7861, LibreDWG - Tasks: task #12284,...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7861: LibreDWG - Tasks: task #12284, compile with -std=c99
Submitter: | James Michael DuPont <mdupont> | ||
Submitted: | Sat 13 Oct 2012 05:37:57 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Invalid | Privacy: | Public |
Assigned to: | reini_urban | Open/Closed: | Closed |
Wed 25 Apr 2018 11:10:40 AM UTC, comment #1: |
Reini Urban <reini_urban> |
Sat 13 Oct 2012 05:37:57 AM UTC, original submission:
LibreDWG - Tasks: task #12284, compile with -std=c99 |
James Michael DuPont <mdupont> |
Attached Files
file #26757: 0001-patch-LibreDWG-Tasks-task-12284-compile-with-s.patch added by mdupont (2KiB - text/x-patch)
Depends on the following items: None found
Items that depend on this one
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-04-25 | reini_urban | Status | None | Invalid | |
Assigned to | None | reini_urban | |||
Open/Closed | Open | Closed | |||
2012-10-13 | mdupont | Dependencies | - | task #12284 is dependent | |
2012-10-13 | mdupont | Attached File | - | Added 0001-patch-LibreDWG-Tasks-task-12284-compile-with-s.patch, #26757 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Hi
Thanks for your patch. Long time has gone since then.
I've also looked at your fork at https://github.com/h4ck3rm1k3/libredwg
with some changes.
Since then we already enforce
AC_PROG_CC_C99
so we already compile with C99.
What you added in your patch is simply replacing some static with inline, but I'll rather let the compiler handle that. A normal compiler should be able to decide by it's own if to inline or not, depending on the optimizer settings.
The rest was already done.
Thanks anyway.