patchGNU Autoconf Archive - Patches: patch #7832, Rewrite of AX_CHECK_POSTGRES_DB

 
 

patch #7832: Rewrite of AX_CHECK_POSTGRES_DB

Submitted by:  Olivier Mehani <shtrom>
Submitted on:  Thu 16 Aug 2012 07:40:33 AM UTC  
 
Priority: 5 - NormalStatus: Done
Assigned to: Peter Simons <simons>Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 14 Sep 2012 05:14:03 AM UTC, comment #2:

Hi,

Great!

FYI, I just noticed while browsing the archive that there might be some redundancy in the macros. ax_lib_postgresql.m4 [0] and ax_check_postgres_db.m4 [1] both do libpq detection.

Not sure what should be done about it, though.

[0] http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob;f=m4/ax_lib_postgresql.m4;h=0bc5fb7202c0dd83ff5e0c1d967c34fd1a9d9f36;hb=HEAD
[1] http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob;f=m4/ax_check_postgres_db.m4;h=bcb21dbe58ca87a204d8ee4613f942a9ed5270cb;hb=HEAD

Olivier Mehani <shtrom>
Fri 07 Sep 2012 08:59:31 AM UTC, comment #1:

Hi Olivier,

your patches for AX_CHECK_POSTGRES_DB are now available in the Git repository. Thank your very much for your efforts.

Take care,
Peter

Peter Simons <simons>
Project AdministratorIn charge of this item.
Thu 16 Aug 2012 07:40:33 AM UTC, original submission:

Here are two patches for m4/ax_check_postgres_db.m4.

The first one uses AS_HELP_STRING to format AC_ARG_WITH and makes the messages
slightly more informative.

The second is a substantial rewrite of the macro, while keeping the same default
behaviour.

From the commit message:

It still behaves the same by default, AC_DEFINing HAVE_LIBPQ and setting
variables PQINCPATH and PQLIBPATH, while erroring when either header or
library is found in the default or specified paths.

The logic is however different, where the specified prefixes and/or
incdir and libdir are temporarily added to CFLAGS and LDFLAGS. The
normal detection logic (AC_CHECK_HEADER and AC_CHECK_LIB) is used next,
only, and once.

In addition, two optional arguments to the macro, ACTION-IF-FOUND and
ACTION-IF-NOT-FOUND are now available to extend the logic. The default
ACTION-IF-FOUND is to do nothing (apart from defining the variables and
substitutions, which is always done). The default ACTION-IF-NOT-FOUND is
to error out; it is replaced by the ACTION-IF-NOT-FOUND if specified
to, e.g., gracefully remove configure PGSQL out when it's only optional.

Bump serial from 5 to 6.

Olivier Mehani <shtrom>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #26376:  0003-Add-Idir-to-CPPFLAGS-rather-than-CFLAGS.patch added by shtrom (1kB - text/x-patch - Add -Idir to CPPFLAGS rather than CFLAGS)
file #26368:  0002-Substantial-rewrite-of-AX_CHECK_POSTGRES_DB.patch added by shtrom (6kB - text/x-patch - Patches are from a different repository where I imported the macro, but they should apply cleanly.)
file #26367:  0001-Use-AS_HELP_STRING-in-ax_check_postgres_db.m4.patch added by shtrom (1kB - text/x-patch - Patches are from a different repository where I imported the macro, but they should apply cleanly.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by simons (Posted a comment)
  • -unavailable- added by simons
  • -unavailable- added by shtrom (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 09 Sep 2012 09:03:33 PM UTCsimonsStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Fri 07 Sep 2012 08:59:31 AM UTCsimonsStatusNone=>Ready For Test
      Assigned toNone=>simons
      Carbon-Copy-=>Added christian toepp
    Fri 17 Aug 2012 06:42:49 AM UTCshtromAttached File-=>Added 0003-Add-Idir-to-CPPFLAGS-rather-than-CFLAGS.patch, #26376
    Thu 16 Aug 2012 07:40:34 AM UTCshtromAttached File-=>Added 0002-Substantial-rewrite-of-AX_CHECK_POSTGRES_DB.patch, #26368
    Thu 16 Aug 2012 07:40:33 AM UTCshtromAttached File-=>Added 0001-Use-AS_HELP_STRING-in-ax_check_postgres_db.m4.patch, #26367

    Back to the top


    Powered by Savane 3.1-cleanup