Gnash - The GNU Flash player - Patches: patch #7575, No memcpy when endian-swapping...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7575: No memcpy when endian-swapping input
Submitter: | Jonas 'Sortie' Termansen <sortie> | ||
Submitted: | Sun 10 Jul 2011 10:22:29 PM UTC | ||
Category: | sound | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Jump to the original submission
Tue 12 Jul 2011 07:48:05 PM UTC, comment #7: |
Sandro Santilli <strk> |
Tue 12 Jul 2011 06:59:59 PM UTC, comment #6: Did you test on a Big-Endian CPU? I only touched the BE path of execution. |
Jonas 'Sortie' Termansen <sortie> |
Tue 12 Jul 2011 08:31:33 AM UTC, comment #5: Alright, manual test shows that sortie's patch actually fixes playback of uncompressed sound here.
|
Sandro Santilli <strk> |
Tue 12 Jul 2011 08:15:59 AM UTC, comment #4: Ok, as of 55a441446fb57851dcc61a950083f9726df613f0, the GST MediaHandler will successfully create an audio decoder for UNCOMPRESSED sound, using AudioDecoderSimple.
|
Sandro Santilli <strk> |
Mon 11 Jul 2011 04:20:34 PM UTC, comment #3: Note that ffmpeg uses its own decoder for UNCOMPRESSED sound while GST seems to be just giving up after attempting to find a proper GST decoder:
|
Sandro Santilli <strk> |
Mon 11 Jul 2011 02:33:37 PM UTC, comment #2: I've verified there's currently no test for raw sound in our testsuite. |
Sandro Santilli <strk> |
Mon 11 Jul 2011 01:58:38 PM UTC, comment #1: It is very important when doing work on performance optimization to make sure that the change doesn't break anything. For sound this is particularly hard as we don't have many tests.
|
Sandro Santilli <strk> |
Sun 10 Jul 2011 10:22:29 PM UTC, original submission:
Just a small inefficiency I found when looking over AudioDecoderSimple. It copied the input data to the output buffer, and then endian-swapped the entire buffer. This results in 2 read, 1 swap, and 2 write operations for each 16-bit word.
|
Jonas 'Sortie' Termansen <sortie> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2011-07-12 | strk | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2011-07-11 | strk | Status | None | In Progress | |
Assigned to | None | strk | |||
2011-07-10 | sortie | Attached File | - | Added 0001-Don-t-memcpy-data-if-you-need-to-endian-swap-it-anyw.patch, #23637 |
Powered by Savane 3.13-4b48.
Corresponding source code
No, little-endian only, but still saw your patch (in addition to 55a441446f) being required to get any sound out.
Did you test it ?