patchGNU Autoconf Archive - Patches: patch #7562, [PATCH] AX_C_CHECK_FLAG: Do not...

 
 

patch #7562: [PATCH] AX_C_CHECK_FLAG: Do not use AC_PROG_SED

Submitter:  Anders Kaseorg <anders>
Submitted:  Fri 24 Jun 2011 08:56:29 PM UTC
 
Priority:  5 - Normal Status:  Wont Do
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Sat 25 Jun 2011 09:01:55 AM UTC, comment #4: 

Now I come to think about it, there probably should be some effort to replace most of the sed invocations in all macros by m4_bpatsubst and m4_translit. I think those two functions cover the vast majority of the uses of sed and should result in faster macros.

Maarten Bosmans <mkbosmans>
Sat 25 Jun 2011 08:53:35 AM UTC, comment #3: 

The new macro AX_CHECK_COMPILE_FLAG replaces this macro, and it doesn't depend on sed anymore.

Peter Simons <simons>
Project Administrator
Sat 25 Jun 2011 08:50:06 AM UTC, comment #2: 

There are more macros like this: cxx cpp cxxcpp and ld variant. Those should be changed also.

But more importantly, it is not necessary to use sed at all. You can use m4_bpatsubst, or better yet AS_TR_SH, or better yet AS_VAR_PUSHDEF. Those seems to be available at least prior to 2.51.

Please have a look at the mails I sent to the list (june 20)
http://lists.gnu.org/archive/html/autoconf-archive-maintainers/2011-06/index.html
to propose a solution for all these macros (and several other, very similar ones)

Maarten Bosmans <mkbosmans>
Sat 25 Jun 2011 08:47:11 AM UTC, comment #1: 

AC_PROG_SED is required to ensure that sed is found in $PATH. If sed cannot be found, then the macro is most probably going to fail without a useful error message, because the call the sed is part of a pipe construct.

Peter Simons <simons>
Project Administrator
Fri 24 Jun 2011 08:56:29 PM UTC, original submission:  
Anders Kaseorg <anders>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #23556:  ax_c_check_flag-sed.patch added by anders (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mkbosmans (Posted a comment)
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by anders (Submitted the item)
  •  

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-06-25 simons Open/ClosedOpen Closed
    2011-06-25 simons StatusNone Wont Do
        Assigned toNone simons
    2011-06-24 anders Attached File- Added ax_c_check_flag-sed.patch, #23556

    Back to the top


    Powered by Savane 3.9