patchGNU Autoconf Archive - Patches: patch #7552, Add check for PTHREAD_PRIO_INHERIT...

 
 

patch #7552: Add check for PTHREAD_PRIO_INHERIT to ax_pthread

Submitted by:  Maarten Bosmans <mkbosmans>
Submitted on:  Fri 10 Jun 2011 11:31:32 AM UTC  
 
Priority: 5 - NormalStatus: Done
Assigned to: Peter Simons <simons>Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 25 Jun 2011 09:04:37 AM UTC, comment #8:

Nice. Latest version tested and is fine.
Please close this bug.

Maarten Bosmans <mkbosmans>
Tue 21 Jun 2011 08:15:25 AM UTC, comment #7:

The latest patch has been applied in commit c80bbb57a2779a81242160b4f6ef9727fa5c9642. Thanks!

Peter Simons <simons>
Project AdministratorIn charge of this item.
Thu 16 Jun 2011 05:46:32 PM UTC, comment #6:

Here is the patch for the latest suggestion:

--- ax_pthread.m4.old 2011-06-16 19:31:18.549809899 +0200
+++ ax_pthread.m4 2011-06-16 19:44:01.933810275 +0200
@@ -33,6 +33,9 @@
# has a nonstandard name, defines PTHREAD_CREATE_JOINABLE to that name
# (e.g. PTHREAD_CREATE_UNDETACHED on AIX).
#
+# Also HAVE_PTHREAD_PRIO_INHERIT is defined if pthread is found and the
+# PTHREAD_PRIO_INHERIT symbol is defined when compiling with PTHREAD_CFLAGS.
+#
# ACTION-IF-FOUND is a list of shell commands to run if a threads library
# is found, and ACTION-IF-NOT-FOUND is a list of commands to run it if it
# is not found. If ACTION-IF-FOUND is not specified, the default action
@@ -78,7 +81,7 @@
# modified version of the Autoconf Macro, you may extend this special
# exception to the GPL to apply to your modified version as well.

-#serial 13
+#serial 14

AU_ALIAS([ACX_PTHREAD], [AX_PTHREAD])
AC_DEFUN([AX_PTHREAD], [
@@ -266,6 +269,8 @@
[ax_cv_PTHREAD_PRIO_INHERIT=yes],
[ax_cv_PTHREAD_PRIO_INHERIT=no])
])
+ AS_IF([test "x$ax_cv_PTHREAD_PRIO_INHERIT" = "xyes"],
+ AC_DEFINE([HAVE_PTHREAD_PRIO_INHERIT], 1, [Have PTHREAD_PRIO_INHERIT.]))

LIBS="$save_LIBS"
CFLAGS="$save_CFLAGS"

Maarten Bosmans <mkbosmans>
Thu 16 Jun 2011 04:19:59 PM UTC, comment #5:

I agree. Both because the cpp symbol name should be standardized, and also because cache variables are something of an implementation detail that should (preferably) not be used in configure.ac.

Daniel Richard G. <iskunk>
Thu 16 Jun 2011 03:40:57 PM UTC, comment #4:

Uhm, yes. In my configure.ac it is used like this:

AX_PTHREAD

AS_IF([test "$ax_cv_PTHREAD_PRIO_INHERIT" = "yes"],
AC_DEFINE([HAVE_PTHREAD_PRIO_INHERIT], 1, [Have PTHREAD_PRIO_INHERIT.]))

I guess it makes sense to include that snippet directly into AX_PTHREAD.

Maarten Bosmans <mkbosmans>
Thu 16 Jun 2011 03:13:41 PM UTC, comment #3:

I might be missing something here, but shouldn't there be an AC_DEFINE([HAVE_PTHREAD_PRIO_INHERIT]) or the like in there? All this check is doing is setting a cache variable.

Daniel Richard G. <iskunk>
Thu 16 Jun 2011 02:59:40 PM UTC, comment #2:

I couldn't find a button to close the bug, so just reporting that the commit is fine with this comment.

Maarten Bosmans <mkbosmans>
Wed 15 Jun 2011 10:49:20 AM UTC, comment #1:

Hi Maarten,

your patch has been applied in commit 3b4f1719a411fec4fb12949f9c62488fb0f08f96. Thank you very much!

Take care,
Peter

Peter Simons <simons>
Project AdministratorIn charge of this item.
Fri 10 Jun 2011 11:31:32 AM UTC, original submission:
Maarten Bosmans <mkbosmans>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23517:  ax_pthread.m4.patch added by mkbosmans (613B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by iskunk (Posted a comment)
  • -unavailable- added by simons (Posted a comment)
  • -unavailable- added by simons
  • -unavailable- added by simons
  • -unavailable- added by mkbosmans (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 25 Jun 2011 09:04:03 AM UTCsimonsStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Wed 15 Jun 2011 10:49:20 AM UTCsimonsStatusNone=>Ready For Test
      Assigned toNone=>simons
      Carbon-Copy-=>Added steven g. johnson
      Carbon-Copy-=>Added daniel richard g.
    Fri 10 Jun 2011 11:31:32 AM UTCmkbosmansAttached File-=>Added ax_pthread.m4.patch, #23517

    Back to the top


    Powered by Savane 3.1-cleanup