patchGNU nano - Patches: patch #7550, Fix for bug #26111 (multi-line...


You are not allowed to post comments on this tracker with your current authentication level.

patch #7550: Fix for bug #26111 (multi-line syntax highlighting broken)

Submitted by:  Ryan Lothian <ryanlothian>
Submitted on:  Thu Jun 9 23:32:20 2011  
Priority: 5 - NormalStatus: Done
Privacy: PublicAssigned to: Benno Schulenberg <bens>
Open/Closed: ClosedRelease: None

Sat May 17 20:30:07 2014, comment #3:

A near-equivalent of your patch went into SVN, r4902.


Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri Feb 21 20:35:02 2014, comment #2:

My fault. Don't know what I did wrong, but I can reproduce it now. And your patch makes it go away. Cool. Looking into it.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri Feb 14 12:58:25 2014, comment #1:

Hi Ryan. Can you still reproduce this overcoloring with current nanos (2.2.6, 2.3.2, or svn)? I can't.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Thu Jun 9 23:32:20 2011, original submission:

This patch fixes Savannah bug 26111.

Reproducing the issue: I was able to reproduce the issue with the example given in 26111, using the latest nano from SVN (4546) and with c.nanorc with the final (trailing whitespace coloring) rule commented out.

Cause: The coloring loop in winio.c contains continue statements, so the wattroff calls at the end of each loop iteration are not always called.

Fix: This patch moves the wattroff calls to the for-loop, so they are called for every iteration. After applying the patch, the example C file in 26111 was colored correctly.

Ryan Lothian <ryanlothian>


Attached Files


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by ryanlothian (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat May 17 20:30:07 2014bensStatusNeed Info=>Done
    Fri Feb 21 20:35:02 2014bensAssigned toNone=>bens
      SummaryFix for Savannah bug 26111 (multi-line syntax highlighting broken)=>Fix for bug #26111 (multi-line syntax highlighting broken)
    Fri Feb 14 12:58:25 2014bensStatusNone=>Need Info
    Thu Jun 9 23:32:20 2011ryanlothianAttached File-=>Added nano-highlight-patch.diff, #23515

    Back to the top

    Powered by Savane 3.1-cleanup1