patchGNU Autoconf Archive - Patches: patch #7411, Bug: ax_check_zlib.m4 does not...

 
 

patch #7411: Bug: ax_check_zlib.m4 does not honour --with-zlib=DIR

Submitted by:  None
Submitted on:  Sun 12 Dec 2010 01:50:41 PM UTC  
 
Priority: 5 - NormalStatus: Done
Assigned to: Peter Simons <simons>Originator Email: -unavailable-
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 23 Dec 2010 01:54:33 PM UTC, comment #3:

Hi,

your patch has been applied in commit 9f0e19e0ecd288fdf1ae30a49a8b5703c844e229. Thank you very much for the submission!

Take care,
Peter

Peter Simons <simons>
Project AdministratorIn charge of this item.
Sun 19 Dec 2010 10:52:35 PM UTC, comment #2:

Hi Peter,

sure. New attached version does not set anything outside the macro call, also checks for 'usual places' of MacPorts and fink on OSX (if not found under /usr/local and /usr, which is probably not the case for many installations). The rewritten part has grown a bit.

Version attached tested on Linux (Kubuntu 9.10) and OSX (10.6) but should work on any other UNIX though (*BSD, AIX, HPUX, Solaris, etc.)

Best,
Bastien

(file #22239)

Anonymous
Sat 18 Dec 2010 05:15:56 PM UTC, comment #1:

Hi Bach,

thank you very much for the patch. I wonder, though, whether it's a good idea to add the assignment "ZLIB_HOME=/usr/local" at the top of the file, i.e. outside of the macro definition? This means that just including the m4 file will set that variable, even if the macro itself is never called. It's certainly uncommon for autoconf macros to behave that way. Do you think there's a way to move that assignment into the macro body?

Take care,
Peter

Peter Simons <simons>
Project AdministratorIn charge of this item.
Sun 12 Dec 2010 01:50:41 PM UTC, original submission:

Hi there,

I found this out while tinkering with a system (OSX) that does not have a ZLIB installed at the default place (/usr/local or /usr): ax_check_zlib.m4 does not honour --with-zlib=DIR

In fact, it overwrites the value supplied via command line just after having asked for it.

The attached file corrects this.

Best,
Bastien

PS: if wanted I could write a version which also checks "the usual places" from different unix port packages on OSX (MacPorts, fink, etc.)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22239:  ax_check_zlib.m4 added by None (5kB - application/octet-stream - New version, not setting any variable if not called, checking for 'usual places' on OSX)
file #22183:  ax_check_zlib.m4 added by None (5kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by simons (Posted a comment)
  • -unavailable- added by simons (Original author)
  • -unavailable- added by None (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 02 Jan 2011 11:14:27 AM UTCsimonsStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Thu 23 Dec 2010 01:54:33 PM UTCsimonsStatusNeed Info=>Ready For Test
    Sun 19 Dec 2010 10:52:35 PM UTCNoneAttached File-=>Added ax_check_zlib.m4, #22239
    Sat 18 Dec 2010 05:16:14 PM UTCsimonsStatusNone=>Need Info
      Assigned toNone=>simons
    Sat 18 Dec 2010 05:15:56 PM UTCsimonsCarbon-Copy-=>Added loic dachary
    Sun 12 Dec 2010 01:50:42 PM UTCNoneAttached File-=>Added ax_check_zlib.m4, #22183

    Back to the top


    Powered by Savane 3.1-cleanup