patchGNU Autoconf Archive - Patches: patch #7291, AX_CFLAGS_GCC_OPTION: Correct...


patch #7291: AX_CFLAGS_GCC_OPTION: Correct handling of indirectly named sh vars

Submitter:  Peter Kjellerstedt <pkj>
Submitted:  Wed 25 Aug 2010 12:24:12 PM UTC
Priority:  5 - Normal Status:  Done
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)

Comment Type & Canned Response:
       No canned response available


Fri 27 Aug 2010 06:36:44 AM UTC, comment #4: 

Looking good.

Peter Kjellerstedt <pkj>
Thu 26 Aug 2010 05:49:02 PM UTC, comment #3: 

Hi Peter,

I made the changes you requested in 591a2370b649bcb35d1c9c65c2d1ccbcf3444a22. Does the result look okay?

Take care,

Peter Simons <simons>
Project Administrator
Thu 26 Aug 2010 03:25:40 PM UTC, comment #2: 

Ouch, you were a bit too fast. We just noticed a problem when using the updated macro with an older version of autoconf (e.g., 2.61 as used by debian). AS_VAR_COPY() seems to be a relatively new addition to the API, and did not exist in 2.61. On the other hand it is deprecated with newer versions of autoconf (which is why I used AS_VAR_COPY() in the first place).

Can you please replace the four lines with AS_VAR_COPY with this line:


Peter Kjellerstedt <pkj>
Wed 25 Aug 2010 08:09:56 PM UTC, comment #1: 

Hi Peter,

your patch has been committed in revision acb306ce125b3e7d6df709940fc0d159ab35cf11.

Thank you very much for the submission!

Take care,

Peter Simons <simons>
Project Administrator
Wed 25 Aug 2010 12:24:12 PM UTC, original submission:  

With autoconf 2.67 a use of AX_CFLAGS_GCC_OPTION() like this

    AX_CFLAGS_GCC_OPTION([-fvisibility=hidden], AM_CFLAGS)

with an option containing a non-literal character like = suddenly breaks. This was due to directly accessing variables defined with AS_VAR_PUSHDEF(), rather than using AS_VAR_SET() and AS_VAR_COPY().

I am no m4 hacker, so I do not guarantee my changes are correct, but I do get the expected result both with autoconf 2.65 and autoconf 2.67 after my changes.

Also, I did not update the #serial as I assume this is done automatically.

Peter Kjellerstedt <pkj>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by simons
  • -email is unavailable- added by pkj (Submitted the item)




    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-08-27 simons StatusReady For Test Done
        Open/ClosedOpen Closed
    2010-08-26 simons StatusDone Ready For Test
        Open/ClosedClosed Open
    2010-08-25 simons StatusNone Done
        Assigned toNone simons
        Open/ClosedOpen Closed
        Carbon-Copy- Added guido u. draheim
    2010-08-25 pkj Attached File- Added 0001-AX_CFLAGS_GCC_OPTION-Correct-handling-of-indirectly-.patch, #21302

    Back to the top

    Powered by Savane 3.9