patchLibreDWG - Patches: patch #7057, C++ patch

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7057: C++ patch

Submitted by:  James Michael DuPont <mdupont>
Submitted on:  Wed 06 Jan 2010 07:23:40 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Rodrigo Rodrigues da Silva <pitanga> Open/Closed:  Closed

Tue 19 Jan 2010 06:24:00 AM UTC, comment #3: 

Sorry for the delay. The patch's been committed to master. Next time, use git format-patch (and configure git globals properly) if you want the commit under your name. BTW, according to our policy you'll get write access if your next patch gets accepted. Thanks for your contribution, and keep the work going!

Rodrigo Rodrigues da Silva <pitanga>
Project AdministratorIn charge of this item.
Wed 13 Jan 2010 09:08:17 AM UTC, comment #2: 

the declaration on line 70 of src/bits.h should look like this:

void
bit_write_4BITS(Bit_Chain * dat, unsigned char value);

and in the source file:
void
bit_write_4BITS(Bit_Chain * dat, unsigned char value)

New patch will be attached.

(file #19482)

James Michael DuPont <mdupont>
Project Member
Wed 13 Jan 2010 01:33:18 AM UTC, comment #1: 

I'm not sure about the objective of this patch. Things like "using namespace std" would break under GCC. This is a C library, not a C++ library. Can't you just link a C++ program to a GCC compiled library?

BTW, some type castings are useful, I'm still checking them.

After applying this patch, I got an error:

make[2]: Entrando no diretório `/media/disk/rodrigo/devel/libredwg/src'
/bin/bash ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..     -g -O2 -MT bits.lo -MD -MP -MF .deps/bits.Tpo -c -o bits.lo bits.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -MT bits.lo -MD -MP -MF .deps/bits.Tpo -c bits.c  -fPIC -DPIC -o .libs/bits.o
bits.c:155: error: conflicting types for ‘bit_write_4BITS’
bits.h:72: error: previous declaration of ‘bit_write_4BITS’ was here
make[2]: ** [bits.lo] Erro 1
make[2]: Saindo do diretório `/media/disk/rodrigo/devel/libredwg/src'
make[1]: ** [all-recursive] Erro 1
make[1]: Saindo do diretório `/media/disk/rodrigo/devel/libredwg'
make: ** [all] Erro 2

Do you get this too?

Rodrigo Rodrigues da Silva <pitanga>
Project AdministratorIn charge of this item.
Wed 06 Jan 2010 07:23:40 PM UTC, original submission:  

Build like this :
make CC=g++

Build example like this:
make CC=g++ testSVG CFLAGS=-save-temps LDFLAGS=-L../src

James Michael DuPont <mdupont>
Project Member

 

Attached Files
file #19482:  patchnew.diff added by mdupont (31KiB - text/x-patch - New patch)
file #19422:  patch.diff added by mdupont (27KiB - text/x-patch - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by pitanga (Posted a comment)
  • -email is unavailable- added by mdupont (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-01-19 pitanga StatusReady For Test => Done
        Open/ClosedOpen => Closed
        Discussion LockUnlocked => Locked
    2010-01-13 pitanga StatusNeed Info => Ready For Test
        Assigned toNone => pitanga
    2010-01-13 mdupont Attached File- => Added patchnew.diff, #19482
    2010-01-13 pitanga StatusNone => Need Info
    2010-01-06 mdupont Attached File- => Added patch.diff, #19422

    Back to the top


    Powered by Savane 3.5