patchGNU nano - Patches: patch #7013, SVN r4458: Several refresh-related...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #7013: SVN r4458: Several refresh-related fixes

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Fri 04 Dec 2009 07:25:47 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed
Release: None

Thu 15 May 2014 09:34:46 PM UTC, comment #3:

Refresh has been added to the Help menu, mainly to get the help items to line up nicely. Apart from the main editor window, I don't see much use for having Refresh -- it is easy enough to hit ^Cancel and redo the action. But in the main window it is annyoing to have to exit and restart nano when the screen is messed up, or to think of hitting ^G twice -- then it is nice to have ^L. And I used it the other day, for the first time ever, when some stray messages intruded.

Part of the patch was applied in r4780.

Benno Schulenberg <bens>
Project MemberIn charge of this item.
Mon 07 Dec 2009 09:44:16 PM UTC, comment #2:

Okay; thanks. You know the current menu code better than I do anyway :)

David Lawrence Ramsey <dolorous>
Project Administrator
Mon 07 Dec 2009 12:49:04 PM UTC, comment #1:

Now this one is interesting. I'm certainly for aligning the exit text in all the available menus including help. However, as written this patch introduces Refresh into a few menus where I don't think it should be, e.g. the whereis/replace menu. I think this is as easy as moving down either the the add_to_funcs entry or add_to-sclist for menus where we don't want to see refresh. I'll try and have a looksee at this tonight.

Chris Allegretta <astyanax>
Project Administrator
Fri 04 Dec 2009 07:25:47 PM UTC, original submission:

In trunk SVN r4458, Refresh is only available for the main shortcut list and the help browser. According to the code, refreshing is supposed to work everywhere (even the Yes/No/All prompt). The attached patch fixes this, along with two related issues in the help browser:

1. In nano 2.0.x, Refresh is in place of the "Get Help" shortcut in the help browser, so as to align the page-scrolling shortcuts properly (which is currently done by putting Exit after the page-scrolling shortcuts). The patch restores the 2.0.x order, making Refresh a visible help browser shortcut again in the process.

2. An erroneous break is removed from do_help(), so that pressing Ctrl-L to refresh doesn't kick the user out of the help browser.

David Lawrence Ramsey <dolorous>
Project Administrator

 

Attached Files
file #19200:  refresh4458.patch added by dolorous (3kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by astyanax (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 17 May 2014 11:52:01 AM UTCbensStatusIn Progress=>Done
      Assigned toastyanax=>bens
      Open/ClosedOpen=>Closed
    Mon 07 Dec 2009 12:49:04 PM UTCastyanaxStatusNone=>In Progress
      Assigned toNone=>astyanax
    Fri 04 Dec 2009 07:25:47 PM UTCdolorousAttached File-=>Added refresh4458.patch, #19200

    Back to the top


    Powered by Savane 3.1-cleanup