patchGNU nano - Patches: patch #6873, support for 256 colors

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6873: support for 256 colors

Submitter:  Dave Lemonby <dreamlax>
Submitted:  Mon 20 Jul 2009 01:21:54 AM UTC
Votes: 70
 
Priority:  5 - Normal Status:  Wont Do
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  None

Jump to the original submission

Fri 31 Jul 2020 08:09:00 AM UTC, comment #8: 

Hello Dave,

Thanks for responding.  Yes, named colors are more user friendly, but they are rather limited.  If people continue to request more colors, I may reconsider and add indexes or three-digit true colors.

Benno Schulenberg <bens>
Group administrator
Thu 30 Jul 2020 01:07:58 PM UTC, comment #7: 

Sorry for the delay. Your approach is much more user friendly. Also, 11 years ago I was not that great at coding and didn't really know how to generate a patch (or devise a decent system for multicolour support).

I think your approach is nicer. I think this issue can be closed.

Dave Lemonby <dreamlax>
Thu 18 Jun 2020 01:54:57 PM UTC, comment #6: 

Support for nine extra named colors has been added in commit f6e7b7fb.  I think this is a nicer way to handle colors than with indexes, and that it will do for most users.  What do you think?

Benno Schulenberg <bens>
Group administrator
Thu 30 Oct 2014 08:15:42 PM UTC, comment #5: 

Hello Dave,

I produced the actual diff for comparison with a different 256-colours patch that was submitted recently -- see https://lists.gnu.org/archive/html/nano-devel/2014-10/msg00000.html and the author's comments on yours in https://lists.gnu.org/archive/html/nano-devel/2014-10/msg00034.html

If you wish, please join the discussion on the devel list.  I am not hearing any votes or arguments in one direction or the other, so I am holding off on applying any.

Benno Schulenberg <bens>
Group administrator
Wed 29 Oct 2014 03:23:16 AM UTC, comment #4: 

Hi, sorry for the delay. My account at Savannah was using an old email address, so I didn't get the original notification in April 2014. Is there anything that you would like me to do regarding this patch?

Dave Lemonby <dreamlax>
Tue 21 Oct 2014 07:26:42 PM UTC, comment #3: 

Attached is the difference between r4375 and the file posted by Dave, resulting in the patch that I wished to see.

(file #32306)

Benno Schulenberg <bens>
Group administrator
Tue 08 Apr 2014 12:59:00 PM UTC, comment #2: 

If you are still interested in this feature, could you resubmit this as an actual patch against SVN?

Benno Schulenberg <bens>
Group administrator
Mon 20 Jul 2009 01:35:01 AM UTC, comment #1: 

Hi,

I forgot to mention, I have tested it using gnome-terminal, konsole, and xterm-256color. For ncurses to determine 256-color eligibility, the TERM environment variable should be set to xterm-256color. Xterm may need to be recompiled with --enable-256color.

Cheers,
Dave.

Dave Lemonby <dreamlax>
Mon 20 Jul 2009 01:21:54 AM UTC, original submission:  

Hi,

I've added 256 colour support to nano's RC parser. Colours outside of the standard 16 colours can be used in nano by providing the following format:

# regular style
color green "regex"

# palette style
color 192 "regex"

# RGB style
# components must be between 0 and 5 inclusive.
color 4:5:1 "regex"

# grayscale style
color gray12 "regex"

I have not included any error checking (there is some primitive integer range checking) or terminal capability checking.

Cheers,
Dave

Dave Lemonby <dreamlax>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #32306:  dreamlax-color.patch added by bens (1KiB - text/x-diff)
file #18441:  rcfile.c added by dreamlax (29KiB - text/x-csrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gnumeregan (Voted in favor of this item)
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by dreamlax (Submitted the item)
  •  

    There are 70 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-31 bens StatusNeed Info Wont Do
        Open/ClosedOpen Closed
    2017-12-31 gnumeregan Carbon-Copy- Added gnumeregan
    2014-10-30 bens Summary256 color support patch support for 256 colors
    2014-10-21 bens Attached File- Added dreamlax-color.patch, #32306
    2014-04-08 bens StatusNone Need Info
    2009-07-20 dreamlax Attached File- Added rcfile.c, #18441

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code