patchGnash - The GNU Flash player - Patches: patch #6665, Build failed with...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6665: Build failed with gstreamer-plugins-base 0.10.14

Submitter:  Martin Sidaway <martin_s>
Submitted:  Tue 04 Nov 2008 06:51:29 PM UTC
   
 
Category:  build Priority:  9 - Immediate
Status:  Done Privacy:  Public
Assigned to:  nelsonrn Open/Closed:  Closed

Wed 05 Nov 2008 11:28:44 PM UTC, comment #2: 

Agreed, this patch looks reasonable.  Applied.

Russ Nelson <nelsonrn>
Wed 05 Nov 2008 08:28:43 AM UTC, comment #1: 

Nelson, could you review and apply ?
Also, can you figure a way to include patches into the
things to do before closing a release ?

Sandro Santilli <strk>
Group Member
Tue 04 Nov 2008 06:51:29 PM UTC, original submission:  

Installed libgstreamer-plugins-base0.10-dev (version: 0.10.14) on Ubuntu 7.10.

Ran ./configure (on the trunk version I bzr'd yesterday), which gave no warning about the gstreamer install plugin being the wrong version. After configuration, gnashconfig.h had GST_HAS_MODERN_PBUTILS defined.

Part way through the build, got an error compiling libmedia/gst/GstUtil.cpp. It was complaining about gst_install_plugins_supported() not being declared.

I noted in the documentation that this function is only present in gstreamer-plugins-base since 0.10.15, while my version is 0.10.14:

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstpbutilsinstallplugins.html#gst-install-plugins-supported

I also noted that a define in gnashconfig.h, HAVE_GST_INSTALL_PLUGINS_SUPPORTED, was commented out. I therefore thought it might be appropriate to have the call to this function inside an #ifdef (as it seems the program can carry on without it). However, trying this, I found that it then complained about gst_missing_decoder_installer_detail_new(), which seems rather more essential.

Checking the documentation, I found that this function was also introduced in version 0.10.15. So it seems that the GST_HAS_MODERN_PBUTILS code will not work before this version.

So, I modified the configure.ac script to (effectively) check for version 0.10.15 (by making sure gst_install_plugins_supported() is present before setting has_modern_gstpbutils=1 and defining GST_HAS_MODERN_PBUTILS), and changed the "RECOMMENDED" message to indicate that the version installed must be >= 0.10.15.

Martin Sidaway <martin_s>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16787:  gst_install_patch.diff added by martin_s (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nelsonrn (Posted a comment)
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by martin_s (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-01-08 strk StatusReady For Test Done
        Open/ClosedOpen Closed
    2008-11-05 nelsonrn StatusNone Ready For Test
    2008-11-05 strk Priority5 - Normal 9 - Immediate
        Assigned toNone nelsonrn
    2008-11-04 martin_s Attached File- Added gst_install_patch.diff, #16787

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code