patchGnash - The GNU Flash player - Patches: patch #6334, Caching in gnash::stream


You are not allowed to post comments on this tracker with your current authentication level.

patch #6334: Caching in gnash::stream

Submitter:  Sandro Santilli <strk>
Submitted:  Fri 07 Dec 2007 11:56:50 AM UTC
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open

Wed 12 Dec 2007 03:24:00 PM UTC, comment #2: 

attached an updated patch cleanly applying to head, and raising cache capacity to 512 bytes.

(file #14608)

Sandro Santilli <strk>
Group Member
Fri 07 Dec 2007 12:04:28 PM UTC, comment #1: 

Started a wiki page as a place for redesign discussion:

Sandro Santilli <strk>
Group Member
Fri 07 Dec 2007 11:56:50 AM UTC, original submission:  

This patch implements a fixed-size cache in gnash::stream class
filled on first bitwise read and used till empty.
The patch gave me no regressions and dramatically
reduced tu_file based seeks (sometimes triggering complete
decompression from start).

With this patch loading the ninja movie performs 80k calls
to low-level input rather then 18m (1/1000). Only tested the
case in which low-level call is std_read_func (loading from filesystem), no idea what would that mean for network-loaded

Note that the bitwise reading functions in this patch are not
optimized so you don't see a big speed improvement, anyway
the patch provides a cache which may be used to implement those

I'm suspending further work on it as I think we need an
to take a top-down design of data flow to really optimize
buffers (to avoid the data to be copied in memory between

Sandro Santilli <strk>
Group Member


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #14608:  CachingStream2.patch added by strk (13KiB - text/x-patch)
file #14584:  CachingStream.patch added by strk (13KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by strk (Submitted the item)
  • -email is unavailable- added by strk
  • -email is unavailable- added by strk

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-12-12 strk Attached File- Added CachingStream2.patch, #14608
    2007-12-07 strk Attached File- Added CachingStream.patch, #14584
        Carbon-Copy- Added udog
        Carbon-Copy- Added zoulunkai

    Back to the top

    Powered by Savane 3.12