patchGnash - The GNU Flash player - Patches: patch #6294, Use libmedia from NetStream and...


You are not allowed to post comments on this tracker with your current authentication level.

patch #6294: Use libmedia from NetStream and Sound

Submitted by:  Tomas Groth <tgc>
Submitted on:  Fri 30 Nov 2007 12:54:44 AM UTC  
Category: NonePriority: 5 - Normal
Status: Wont DoPrivacy: Public
Assigned to: Bastiaan Jacques <bjacques>Open/Closed: Closed

Mon 10 Dec 2007 11:00:21 PM UTC, comment #2:

Updated patch to integrate libmedia, since I doubt tgc's will still apply cleanly.

From memory the main changes are:

MediaFrames are passed as an auto_ptr (just an experiment to fix some leaks, not sure if it's the best way).

Another couple of smart arrays for similiar reasons.

Ffmpeg: works with both embedded and streaming video. Some instability with corrupt non-FLVs, but that's no worse than present code.

Mad: not even looked.

Gstreamer: tried removing thread locking code. It plays embedded video, but with very high CPU usage. Streaming video (FLV) doesn't work. Problems with sound decoding / sound handler seem important, since apparently the MediaBuffer gets filled. Might be NetStream code. Lots of debugging output still there; probably worth abandoning my changes...

Changes to NetStream as listed in comment #1.

(file #14604)

Benjamin Wolsey <bwy>
Project Member
Tue 04 Dec 2007 12:31:21 PM UTC, comment #1:

I've committed some small bugfixes to libmedia in the last couple of days. Along with some other changes to the patched NetStream.cpp (with tgc's patch), I think my working copy is almost as stable as current head.

NetStream's has problems with calls to the MediaBuffer before the decoder has been set up (getAudio and refreshVideo), and in processOnStatusNotifications() a call to the decoder (crashes

They can be fixed by testing whether _decoder.get() exists first, though I'm not sure if this is the right behaviour in processOnStatusNotifications.

Lastly: getBufferTime() needs to return getReqBufferTime.

I'm attaching a NetStream.cpp patch (against head) that incorporates those changes.

(file #14558)

Benjamin Wolsey <bwy>
Project Member
Fri 30 Nov 2007 12:54:44 AM UTC, original submission:

So far it only works for ffmpeg, but gst shouldn't be too far away. Sound hasen't been really tested, but NetStream works...

Tomas Groth <tgc>


Attached Files
file #14604:  media.patch added by bwy (94KiB - text/x-patch)
file #14558:  NetStream.patch added by bwy (13KiB - text/x-patch)
file #14513:  uselibmedia.patch.gz added by tgc (13KiB - application/x-tar)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by bjacques (Updated the item)
  • -unavailable- added by bwy (Updated the item)
  • -unavailable- added by tgc (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 13 Feb 2008 07:48:18 PM UTCbjacquesStatusNone=>Wont Do
    Tue 11 Dec 2007 01:49:29 AM UTCbjacquesAssigned toNone=>bjacques
      SummaryUse libmedie from NetStream and Sound=>Use libmedia from NetStream and Sound
    Mon 10 Dec 2007 11:00:21 PM UTCbwyAttached File-=>Added media.patch, #14604
    Tue 04 Dec 2007 12:31:21 PM UTCbwyAttached File-=>Added NetStream.patch, #14558
    Fri 30 Nov 2007 12:54:44 AM UTCtgcAttached File-=>Added uselibmedia.patch.gz, #14513

    Back to the top

    Powered by Savane 3.1-cleanup1