patchGnash - The GNU Flash player - Patches: patch #6151, Make flash version in description...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6151: Make flash version in description consistent

Submitter:  Benjamin Wolsey <bwy>
Submitted:  Thu 16 Aug 2007 07:05:50 AM UTC
   
 
Category:  plugin Priority:  7 - High
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Jump to the original submission

Thu 13 Nov 2008 10:08:26 PM UTC, comment #7: 

I have seen this same error for many months when loading GNASH in KARTOO.com.  I'm not sure how to see the debug messages.  Is this related to a combination of using adblocker as well as GNASH?

Please comment... thanks!

Asher <asher>
Fri 17 Aug 2007 06:07:54 PM UTC, comment #6: 

It seems the failure was in handling of a FlashParam, should be fixed now, apart from the getUrl opening the actual movie in a new firefox tab. I'd close this item, please open a new one for other problems.

Sandro Santilli <strk>
Group Member
Fri 17 Aug 2007 02:48:52 PM UTC, comment #5: 
Anonymous
Fri 17 Aug 2007 02:33:39 PM UTC, comment #4: 

The first patch only fixes theoretical bugs (as I say, I've never seen a website that requires a specific version number), but you can verify that the SWFobject javascript returns a value for revision with the attached html file. (rev is NaN before the patch).

For the actionscript detector, the following work:

http://www.macromedia.com/software/flash/about/ (the swf is: http://www.macromedia.com/swf/software/flash/about/mini_FMA_about_01.swf)

However, sites using it in practice still fail, not because the version is incorrectly detected (you can check it is now using -va), but rather because of what it's supposed to do afterwards and doesn't.

For instance:

http://www.fxnetworks.com/ and http://www.forensis.com/

(log of the detector from the first site, with $version set to "UNIX 9,0,99,0", attached).

(file #13678, file #13679)

Benjamin Wolsey <bwy>
Group Member
Fri 17 Aug 2007 02:03:03 PM UTC, comment #3: 

I tried using a 3 letter string for the name (in VM.cpp) and that fixed detection on kartoo.com.

Applied both patches, adding some TODO lines as to how to better handle this.
Applied both in head and 0.8.1 branch.

Note that I didn't look at the KPARTS plugin at all.
Also note that the plugin doesn't use the GNASHRC file,
so the only viable option to dynamically change the version
exposed by the plugin is by using an environmental variable
(I didn't provide this capability, just an hint for a future patch).


Sandro Santilli <strk>
Group Member
Fri 17 Aug 2007 01:46:06 PM UTC, comment #2: 

Could you give a couple of URLS to try these detectors and verify your patch fixes them ?

Sandro Santilli <strk>
Group Member
Fri 17 Aug 2007 12:41:18 PM UTC, comment #1: 

Change $version in VM.cpp to allow ActionScript player detection. This fixes the second issue in the original submission and should fix half of bug #19964 (I've explained why it doesn't on the bug).

The Adobe player seems to give the string "UNIX|WIN|WINCE|MAC (major version),(minor version),(revision),0" (deducible from its actionscript detection pack). Determining one of the four OS strings from the build seems more trouble than it's worth, so I've opted for "Gnash" instead. That might cause problems, but at least in the adobe detection kit it's only used when requiring the latest player version.

That makes at least two completely separate strings for version detection, one in the ns plugin description and one as a built-in string (possibly a different one for IE activeX plugin), which are in different places and different forms.

Ideally, they should always agree; even better, they should be derivable from the same place, and perhaps the best way would be if they could all be set in .gnashrc.

(file #13676)

Benjamin Wolsey <bwy>
Group Member
Thu 16 Aug 2007 07:05:50 AM UTC, original submission:  

Defines FLASH_VERSION in plugin/plugin.cpp so that the version description is consistent. It thereby adds a revision number to the beginning of the plugin description so it can be detected by SWFobject.

(It's possible for SWFobject to require a minimum revision number, although I have not found a website that makes use of this feature).

A related issue but not specific to the plugin (and not addressed by the patch):

http://www.macromedia.com/software/flash/about/

doesn't detect a version.

Benjamin Wolsey <bwy>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #13678:  SWFobject.html added by bwy (395B - text/html)
file #13679:  fxnetworks_va.log added by bwy (51KiB - text/x-log)
file #13670:  plugin_description.patch added by bwy (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by asher (Posted a comment)
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by bwy (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-08-17 strk StatusReady For Test Done
        Open/ClosedOpen Closed
    2007-08-17 bwy Attached File- Added SWFobject.html, #13678
        Attached File- Added fxnetworks_va.log, #13679
    2007-08-17 strk StatusIn Progress Ready For Test
    2007-08-17 strk Priority5 - Normal 7 - High
        StatusNone In Progress
        Assigned toNone strk
    2007-08-17 bwy Attached File- Added ActionScript_version_detection.patch, #13676
    2007-08-16 bwy Attached File- Added plugin_description.patch, #13670

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code