patchGnash - The GNU Flash player - Patches: patch #5576, Implements missing AS String Class...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

patch #5576: Implements missing AS String Class methods & adds further tests for AS String Class.

Submitted by:  None
Submitted on:  Tue 21 Nov 2006 08:45:20 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sandro Santilli <strk>Originator Email: -unavailable-
Open/Closed: Closed

Sat 25 Nov 2006 11:06:00 AM UTC, comment #3:

Applied. Thanks !!

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 25 Nov 2006 10:44:49 AM UTC, comment #2:

I now implemented the length property with the new add_property rather than with overriding the get_member method!
Also fixes testsuite/actionscript.all to match the real behaviour.

Michael Meier <meier>
Wed 22 Nov 2006 09:31:08 AM UTC, comment #1:

I've applied the patch, assuming you have tested the String.swf
unit with the official player.
About the 'length' property, there's now support for "Properties",
which are getter/setters members, in the base as_object
class. I didn't try this yet, but the idea is to add a property
for things like 'length' rather then override the get_member
method. It might actually be slower, but code would likely
be much simpler to understand and maintain.
(just in case you feel like trying that).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 21 Nov 2006 08:45:20 PM UTC, original submission:

Following methods of the AS String Class are now also implemted: slice, concat, slice, lastindexof. I also added the member String.length.
I added tests for the new methods and the member in the ActionScipt testcase.

Anonymous

 

Attached Files
file #11354:  stringpatch2.cvsdiff added by meier (2kB - application/octet-stream - Length property now with get_member. String.as fix.)
file #11311:  stringpatch.cvsdiff added by None (7kB - application/octet-stream - Patch for server/asobj/String.cpp and for testsuite/actionscript.all/String.as)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 8 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 25 Nov 2006 10:44:49 AM UTCmeierAttached File-=>Added stringpatch2.cvsdiff, #11354
  Carbon-Copy-=>Added -unavailable-
Wed 22 Nov 2006 09:31:08 AM UTCstrkStatusIn Progress=>Done
  Open/ClosedOpen=>Closed
Wed 22 Nov 2006 09:13:38 AM UTCstrkStatusNone=>In Progress
  Assigned toNone=>strk
Tue 21 Nov 2006 08:45:20 PM UTCNoneAttached File-=>Added stringpatch.cvsdiff, #11311
  Carbon-Copy-=>Added -unavailable-
Show feedback again

Back to the top


Powered by Savane 3.1-cleanup