patchGnash - The GNU Flash player - Patches: patch #5576, Implements missing AS String Class...


You are not allowed to post comments on this tracker with your current authentication level.

patch #5576: Implements missing AS String Class methods & adds further tests for AS String Class.

Submitter:  None
Submitted:  Tue 21 Nov 2006 08:45:20 PM UTC
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Originator Email:  -email is unavailable-
Open/Closed:  Closed

Sat 25 Nov 2006 11:06:00 AM UTC, comment #3: 

Applied. Thanks !!

Sandro Santilli <strk>
Group Member
Sat 25 Nov 2006 10:44:49 AM UTC, comment #2: 

I now implemented the length property with the new add_property rather than with overriding the get_member method!
Also fixes testsuite/actionscript.all to match the real behaviour.

Michael Meier <meier>
Wed 22 Nov 2006 09:31:08 AM UTC, comment #1: 

I've applied the patch, assuming you have tested the String.swf
unit with the official player.
About the 'length' property, there's now support for "Properties",
which are getter/setters members, in the base as_object
class. I didn't try this yet, but the idea is to add a property
for things like 'length' rather then override the get_member
method. It might actually be slower, but code would likely
be much simpler to understand and maintain.
(just in case you feel like trying that).

Sandro Santilli <strk>
Group Member
Tue 21 Nov 2006 08:45:20 PM UTC, original submission:  

Following methods of the AS String Class are now also implemted: slice, concat, slice, lastindexof. I also added the member String.length.
I added tests for the new methods and the member in the ActionScipt testcase.



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11354:  stringpatch2.cvsdiff added by meier (2KiB - application/octet-stream - Length property now with get_member. fix.)
file #11311:  stringpatch.cvsdiff added by None (7KiB - application/octet-stream - Patch for server/asobj/String.cpp and for testsuite/actionscript.all/


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


Follow 8 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-11-25 meier Attached File- Added stringpatch2.cvsdiff, #11354
    Carbon-Copy- Added -email is unavailable-
2006-11-22 strk StatusIn Progress Done
    Open/ClosedOpen Closed
2006-11-22 strk StatusNone In Progress
    Assigned toNone strk
2006-11-21 None Attached File- Added stringpatch.cvsdiff, #11311
    Carbon-Copy- Added -unavailable-

Back to the top

Powered by Savane 3.12