patchidutils - Patches: patch #4953, src/lid.c::isnumber() : Fix for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4953: src/lid.c::isnumber() : Fix for bug in pattern detection

Submitter:  Claudio Fontana <sick_soul>
Submitted:  Sun 05 Mar 2006 10:24:16 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  sick_soul Open/Closed:  Closed

Sun 08 Oct 2006 03:23:49 PM UTC, comment #2: 

I assume changes are ok;
closing item since it's already in CVS.


Claudio Fontana <sick_soul>
Sun 05 Mar 2006 10:29:20 AM UTC, comment #1: 

The attached fix applies to id-utils-4.0 (with -1 line offset) and idutils CVS.

It improves the pattern detection in src/lid.c::is_number()

Apply from the top source directory with:

$ patch -p0 < /path/to/PATCH_FILENAME.p0.udiff
Hunk #1 succeeded at 1368 (offset -1 lines).


Claudio Fontana <sick_soul>
Sun 05 Mar 2006 10:24:16 AM UTC, original submission:  

When trying ftp://prep.ai.mit.edu/gnu/idutils/id-utils-4.0.tar.gz on
FreeBSD 4.3, I noticed that it could not show me uses of the
identifiers
"l" or "u".  It could handle "v" just fine, so it can handle at least
one single character identifier.  Perhaps it is confusing "l" and "u"
with integer constants?

David Sanderson ()

Script started on Fri Mar  3 13:17:36 2006
$ cat foo.c
#ifdef l
#undef l
#endif

#ifdef u
#undef u
#endif

#ifdef v
#undef v
#endif

int l = 1;
int u = 1;
int v = 1;

int main(void)
{
    return l+u+v;
}
$ mkid
$ gid l
$ gid u
$ gid v
foo.c:9:#ifdef v
foo.c:10:#undef v
foo.c:15:int v = 1;
foo.c:19:    return l+u+v;
$ exit

Claudio Fontana <sick_soul>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9649:  lid_pattern_detection_isnumber.p0.udiff added by sick_soul (453B - application/octet-stream - p0 unified diff that fixes the issue)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-10-08 sick_soul StatusReady For Test Done
    Open/ClosedOpen Closed
2006-03-05 sick_soul StatusNone Ready For Test
2006-03-05 sick_soul Attached File- Added lid_pattern_detection_isnumber.p0.udiff, #6013
2006-03-05 sick_soul Carbon-Copy- Added -email is unavailable-

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code