patchgrep - Patches: patch #3767, Remove two match_icase code paths...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3767: Remove two match_icase code paths from prline() in src/grep.c

Submitted by:  Charles Levert <charles_levert>
Submitted on:  Thu 24 Feb 2005 08:19:29 AM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Postponed Privacy:  Public
Assigned to:  None Open/Closed:  Open

( Jump to the original submission)

Wed 22 Aug 2012 05:45:54 PM UTC, comment #6: 

Since the situation with Turkish locales has now been resolved, can this patch be dealt with?

Reuben Thomas <rrt>
Mon 08 Mar 2010 05:05:29 PM UTC, comment #5: 

I think that this can be applied, but I'd rather do this after 2.6 since I'd first like to understand how broken "grep -i" is WRT Turkish locales.

Paolo Bonzini <bonzini>
Tue 21 Jun 2005 04:38:06 PM UTC, comment #4: 

The attached patch no longer applies, but this still will need to be removed from there when the RE_ICASE and regex.[ch] situation is resolved.

Charles Levert <charles_levert>
Mon 13 Jun 2005 11:12:44 PM UTC, comment #3: 

As far as I can tell, this supercedes patch #3805: Red Hat's "icolor" patch, which removes one of these two blocks of code from the grep-2.5.1 source which only had one of them.

Julian Foad <julianfoad>
Sat 05 Mar 2005 06:40:38 PM UTC, comment #2: 

Note that it can be considered a bug that "lib/regex.h" is included even when "./configure --without-included-regex" makes "lib/regex.c" not be compiled nor included in "lib/libgreputils.a".  Changing the #include quotes from "" to <> in "src/search.c" does not resolve this problem because of the "-I../lib".

Charles Levert <charles_levert>
Sat 05 Mar 2005 06:15:41 PM UTC, comment #1: 

Clarification:  for this to be no longer needed, the "grep-2.5.1-oi.patch" patch from Red Hat must first be applied:
  :pserver:anonymous@cvs.fedora.redhat.com:/cvs/dist
  devel/grep/grep-2.5.1-oi.patch
and
  <http://cvs.fedora.redhat.com/viewcvs/devel/grep/>.

Otherwise, should RE_ICASE not be available on all OSes, prline() is still buggy as it stands so this patch #3767 eventually needs to be applied, however another solution in src/search.c must first be found to emulate RE_ICASE for OSes without it (if any).  On the other hand, maybe it's just lib/regex.c that should be updated from a newer glibc versions and older OSes can just rely on that ("./configure --with-included-regex").

Charles Levert <charles_levert>
Thu 24 Feb 2005 08:19:29 AM UTC, original submission:  

In an effort to split patch #3644 in several smaller patches, this patch only removes the two match_icase code paths from prline() in src/grep.c (cvs version 1.93).  These are no longer needed since the addition of equivalent code to check_multibyte_string() in src/search.c (cvs version 1.30).

The deleted code had bugs in it (use of tolower() with possibly UTF-8, and printing tolower()ed substrings as matches).

This should make other patches that apply on top of this one smaller.

Charles Levert <charles_levert>

 

Attached Files
file #8455:  grep.c.diff.cvs-1.93.prline-noicase.charles2a0 added by charles_levert (2KiB - application/octet-stream - actual unidiff patch (not the whole file!))
file #8451:  grep.c.cvs-1.93.prline-noicase.charles2a0 added by charles_levert (46KiB - application/octet-stream - unidiff patch to remove two match_icase code paths from prline() in src/grep.c)

 

Carbon-Copy List
  • -email is unavailable- added by rrt (Posted a comment)
  • -email is unavailable- added by bonzini (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2005-06-21 charles_levert StatusNone => Postponed
    2005-04-12 julianfoad Dependencies- => patch #3644 is dependent
    2005-04-12 julianfoad Dependencies- => Depends on patch #3807
    2005-02-24 charles_levert Attached File- => Added grep.c.diff.cvs-1.93.prline-noicase.charles2a0, #4227
    2005-02-24 charles_levert Attached File- => Added grep.c.cvs-1.93.prline-noicase.charles2a0, #4223

    Back to the top


    Powered by Savane 3.5