patchgrep - Patches: patch #3767, Remove two match_icase code paths...


You are not allowed to post comments on this tracker with your current authentication level.

patch #3767: Remove two match_icase code paths from prline() in src/grep.c

Submitted by:  Charles Levert <charles_levert>
Submitted on:  Thu Feb 24 08:19:29 2005  
Category: NonePriority: 5 - Normal
Status: PostponedPrivacy: Public
Assigned to: NoneOpen/Closed: Open

(Jump to the original submission Jump to the original submission)

Wed Aug 22 17:45:54 2012, comment #6:

Since the situation with Turkish locales has now been resolved, can this patch be dealt with?

Reuben Thomas <rrt>
Mon Mar 8 17:05:29 2010, comment #5:

I think that this can be applied, but I'd rather do this after 2.6 since I'd first like to understand how broken "grep -i" is WRT Turkish locales.

Paolo Bonzini <bonzini>
Tue Jun 21 16:38:06 2005, comment #4:

The attached patch no longer applies, but this still will need to be removed from there when the RE_ICASE and regex.[ch] situation is resolved.

Charles Levert <charles_levert>
Mon Jun 13 23:12:44 2005, comment #3:

As far as I can tell, this supercedes patch #3805: Red Hat's "icolor" patch, which removes one of these two blocks of code from the grep-2.5.1 source which only had one of them.

Julian Foad <julianfoad>
Sat Mar 5 18:40:38 2005, comment #2:

Note that it can be considered a bug that "lib/regex.h" is included even when "./configure --without-included-regex" makes "lib/regex.c" not be compiled nor included in "lib/libgreputils.a". Changing the #include quotes from "" to <> in "src/search.c" does not resolve this problem because of the "-I../lib".

Charles Levert <charles_levert>
Sat Mar 5 18:15:41 2005, comment #1:

Clarification: for this to be no longer needed, the "grep-2.5.1-oi.patch" patch from Red Hat must first be applied:

Otherwise, should RE_ICASE not be available on all OSes, prline() is still buggy as it stands so this patch #3767 eventually needs to be applied, however another solution in src/search.c must first be found to emulate RE_ICASE for OSes without it (if any). On the other hand, maybe it's just lib/regex.c that should be updated from a newer glibc versions and older OSes can just rely on that ("./configure --with-included-regex").

Charles Levert <charles_levert>
Thu Feb 24 08:19:29 2005, original submission:

In an effort to split patch #3644 in several smaller patches, this patch only removes the two match_icase code paths from prline() in src/grep.c (cvs version 1.93). These are no longer needed since the addition of equivalent code to check_multibyte_string() in src/search.c (cvs version 1.30).

The deleted code had bugs in it (use of tolower() with possibly UTF-8, and printing tolower()ed substrings as matches).

This should make other patches that apply on top of this one smaller.

Charles Levert <charles_levert>


Attached Files
file #8455:  grep.c.diff.cvs-1.93.prline-noicase.charles2a0 added by charles_levert (2kB - application/octet-stream - actual unidiff patch (not the whole file!))
file #8451:  grep.c.cvs-1.93.prline-noicase.charles2a0 added by charles_levert (46kB - application/octet-stream - unidiff patch to remove two match_icase code paths from prline() in src/grep.c)


   patch dependencies.

   patch dependencies.


Carbon-Copy List
  • -unavailable- added by rrt (Posted a comment)
  • -unavailable- added by bonzini (Posted a comment)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue Jun 21 16:38:06 2005charles_levertStatusNone=>Postponed
    Tue Apr 12 15:09:31 2005julianfoadDependencies-=>patch #3644 is dependent
    Tue Apr 12 15:06:32 2005julianfoadDependencies-=>Depends on patch #3807
    Thu Feb 24 08:42:12 2005charles_levertAttached File-=>Added grep.c.diff.cvs-1.93.prline-noicase.charles2a0, #4227
    Thu Feb 24 08:19:29 2005charles_levertAttached File-=>Added grep.c.cvs-1.93.prline-noicase.charles2a0, #4223

    Back to the top

    Powered by Savane 3.1-cleanup1