patchfindutils - Patches: patch #3751, Typos and small suggestions to...


You are not allowed to post comments on this tracker with your current authentication level.

patch #3751: Typos and small suggestions to find.texi

Submitted by:  Aaron Hawley <ashawley>
Submitted on:  Fri 18 Feb 2005 09:17:03 AM UTC  
Category:  documentation improvement Priority:  6
Status:  Done Privacy:  Public
Assigned to:  James Youngman <jay> Originator Name: 
Open/Closed:  Closed Release:  None
Fixed Release:  4.2.24

( Jump to the original submission)

Mon 11 Jul 2005 04:03:58 PM UTC, comment #8: 

Changes to perm.texi were sent to the coreutils maintainers as patch #4161.

Aaron Hawley <ashawley>
Wed 29 Jun 2005 10:59:58 PM UTC, comment #7: 

Applied - thanks!

James Youngman <jay>
Project AdministratorIn charge of this item.
Wed 29 Jun 2005 08:30:43 PM UTC, comment #6: 

As mentioned, here is the same changes to find.texi but with
proper whitespace and paragraph filling.  To verify the two
patches are semantically equivalent I ran the following shell
script on them:


rm -f find.texi
cvs upd find.texi
patch < find.texi-1.92-fixes.diff
ps2ascii find-unfilled.ascii

rm -f find.texi
cvs upd find.texi
patch < find.texi-1.92-wspace-fixes.diff
ps2ascii find-filled.ascii

diff -u find-unfilled.ascii find-filled.ascii

### END ###

The output to the diff command was empty last I ran it, meaning
success!  This requires I trust texi2dvi and GNU Ghostscript to
accurately convert the document to ASCII.

Aaron Hawley <ashawley>
Wed 29 Jun 2005 08:26:57 PM UTC, comment #5: 

Here is the patch for find.texi against revision 1.92 in CVS.  This patch has no whitespace changes, so I'll be following this message with the patch with proper whitespace.

Aaron Hawley <ashawley>
Sat 18 Jun 2005 10:10:38 AM UTC, comment #4: 

I would be grateful if you did that.  You have made a copyright assignment, so I should be able to just apply the patch.

Please keep the patch to to perm.texi separate since that's a file we inherit from some other package.  I must find the upstream source for it...

James Youngman <jay>
Project AdministratorIn charge of this item.
Fri 17 Jun 2005 05:15:30 PM UTC, comment #3: 

I've noticed the documentation source files have changed.  I am willing to recreates these patches by combining the changes into a single patch that is against the latest version of the files in CVS.  A patch with properly justified paragraphs (rather than optimized for `diff' readability) can be created, too.

Aaron Hawley <ashawley>
Sun 20 Feb 2005 10:07:18 PM UTC, comment #2: 

Here's a patch with fixes that apply to the Texinfo file perm.texi.  Here's what the patch contains.

  • Proper capitalization for sentences in enumerated lists.
  • Change all uses of "can not" to "cannot".
  • Change "write permission for from" to "write permission for".
  • Change conjunction "plus," to "and".
  • Change "to it file" to "to the file".
Aaron Hawley <ashawley>
Fri 18 Feb 2005 04:36:05 PM UTC, comment #1: 

Last hunk in patch should make the modificatoin of removing the word "of" making the change "but none seem to" and not "but none of seem to".

Also, this patch introduces incorrect whitespace (pararagraph justification) and should probably be fixed.

Aaron Hawley <ashawley>
Fri 18 Feb 2005 09:17:03 AM UTC, original submission:  

Below is a list of documentation fixes included in this patch.

Many of the conclusions I made for consistent markup or spelling were based on how the document handled the situation the majority of the time, and not to some "higher standard".  The exception is formating the "locate" in "locate database". That's my contribution.

Most of the grammatical suggestions are not controversial.  Look forward to those in a future patch, along with general improvements and suggestions to the manual.

If you want me to divide this patch into separate patches, let me know.

  • Change "filename" to "file name"
  • Change one format for 'find' from @samp to @code.
  • Format several uses of 'find' from @samp to @code.
  • Change all mention of arguments as "path(s)" to "file(s)".
  • Change "are different to" to "are different from".
  • Change "test will always fail" to "test will always return false".
  • Change all uses of "file system" to "filesystem".
  • Change "this is the way I normally use this test" to "a common use of this test".
  • Change "might make it a good candidate for deletion" to "might help determine good candidates for deletion".
  • Removed parens around "which can be numeric or symbolic"
  • Change improper use of "full file name" to "entire file name".
  • Change "0 status" to "zero status".
  • Change "command and initial arguments and the terminating nulls" to "command, initial arguments and the terminating nulls".
  • Change "sort each file the" to "sort each file in the".
  • Change "relies on the fact that the shell exits" to "relies on the shell exiting".
  • Change "has no been" to "has not been".
  • Change use of "path" to "file" in "Invoking find" section.
  • Change "status 0" to "status zero".
  • Change "command-line" to "command line".
  • Format "locate" as command with @code{} in all uses of "locate database".
  • Change "links count as if they" to "links as if they were".
  • Removed incorrect "=" for '-a' syntax.
  • Change "or over which other" to "or which other".
  • Change "may" about 'locate' security considerations to "do".
  • Add punctuation (periods) to two bulleted sentences.
  • Formatted any commands in "Error Messages" section titles with @code{}.
  • Removed duplicate "a a".
  • Removed parens around "since the ... set up by the system administrator".
  • Change "It is passed the name" to "It passes to the program the name".
  • Change "their own choice" to "their choice".
  • Change "useful though this option is" to "useful as this option is".
  • Made @samp on actions in table of "Security Summary" section.
  • Mentioned "with find" for actions given in "Security Summary" section.
  • Change "messages you might get" to "messages sometimes made by"
  • Change "figure out which English-language error message the test they actually saw might correspond to" to "figure out which English-language error message corresponds to a test"
  • Add comma after "Firstly".
  • Change "moved the one of the" to "moved one of the".
  • Change "or a something" to "or something".
  • Removed the two accusations in the 'xargs' error messages.
  • Removed use of "me" in the section on 'updatedb' error messages.
  • Change uses of "can not" to "cannot".
Aaron Hawley <ashawley>


Attached Files
file #9015:  find.texi-1.92-wspace-fixes.diff added by ashawley (110KiB - text/plain - diff -u patch with paragraph-filling for find.texi version 1.92)
file #9001:  find.texi-1.92-fixes.diff added by ashawley (33KiB - text/plain - diff -u patch for find.texi version 1.92)
file #8432:  perm.diff added by ashawley (3KiB - text/plain - diff -u patch to perm.texi)
file #8424:  find-1.74-fixes.diff added by ashawley (33KiB - text/plain - diff -u patch for find.texi)


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.




Follow 8 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-29 jay Open/ClosedOpen => Closed
    Fixed ReleaseNone => 4.2.24
2005-06-29 jay StatusNone => Done
    Assigned toNone => jay
2005-06-29 ashawley Attached File- => Added find.texi-1.92-wspace-fixes.diff, #4776
2005-06-29 ashawley Attached File- => Added find.texi-1.92-fixes.diff, #4775
2005-02-20 ashawley Attached File- => Added perm.diff, #4204
2005-02-18 ashawley Attached File- => Added find-1.74-fixes.diff, #4194

Back to the top

Powered by Savane 3.6