GNU nano - Patches: patch #10390, rcfile: map gray #RGB codes to...
You are not allowed to post comments on this tracker with your current authentication level.
patch #10390: rcfile: map gray #RGB codes to xterm grayscale
Submitter: | Andy Koppe <ak2> | ||
Submitted: | Tue 12 Sep 2023 08:16:38 PM UTC | ||
Priority: | 5 - Normal | Status: | Done |
Privacy: | Public | Assigned to: | bens |
Open/Closed: | Open | Release: | None |
Jump to the original submission
Mon 25 Sep 2023 07:37:01 PM UTC, comment #8: |
Andy Koppe <ak2> |
Mon 25 Sep 2023 02:21:02 PM UTC, comment #7: I've settled on this:
(Six steps of 1, four steps of 2, two steps of 3, and one step of 2.)
|
Benno Schulenberg <bens> |
Sat 23 Sep 2023 03:42:16 PM UTC, comment #6: The formula that xterm and friends use for translating the grayscale to RGB values is 8+10*(index-232).
|
Andy Koppe <ak2> |
Sat 23 Sep 2023 09:37:04 AM UTC, comment #5: Thanks. I've tried the different levels. In my opinion the darkest and lightest grey are not useful, as practically invisible on black or white. And the greys near the lower end could use some more steps. So I would like to propose this array:
Could you agree to that? |
Benno Schulenberg <bens> |
Mon 18 Sep 2023 09:26:16 PM UTC, comment #4: Patch v2 with minimal changes attached. |
Andy Koppe <ak2> |
Mon 18 Sep 2023 11:46:20 AM UTC, comment #3: Allowing a darker grey to make the guiding stripe less obtrusive (on a dark background) is a good argument. Maybe good enough to make it worth the code.
|
Benno Schulenberg <bens> |
Sat 16 Sep 2023 11:16:11 AM UTC, comment #2: I agree that 14 gray levels are complete overkill for syntax highlighting. I'm proposing to add them primarily for use in the color settings of nano UI elements.
|
Andy Koppe <ak2> |
Thu 14 Sep 2023 03:19:20 PM UTC, comment #1: The original patch that added #rgb colors had something similar, but I was against it: these colors are meant for syntax highlighting -- why would anyone want fourteen levels of grey? Who can distinguish them? See patch #10131 and search for "gray-scaling". |
Benno Schulenberg <bens> |
Tue 12 Sep 2023 08:16:38 PM UTC, original submission:
When the red, green and blue components of a three-digit hex #RGB code are equal and they aren't #000 for black or #FFF for white, map them to xterm-256color's 24-level grayscale ranging from index 232 to 255.
|
Andy Koppe <ak2> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2023-09-25 | bens | Status | None | Done | |
Assigned to | None | bens | |||
2023-09-18 | ak2 | Attached File | - | Added v2-0001-rcfile-map-gray-RGB-codes-to-xterm-grayscale.patch, #55145 | |
2023-09-12 | ak2 | Attached File | - | Added 0001-rcfile-map-gray-RGB-codes-to-xterm-grayscale.patch, #55131 |
Powered by Savane 3.13-02a9.
Corresponding source code
Great, thank you!