GNU TeXmacs - Bugs: bug #49655, safely-kill-window with qt may...
You are not allowed to post comments on this tracker with your current authentication level.
bug #49655: safely-kill-window with qt may causes corruption and crash when fast_alloc is used
Submitter: | Philippe Joyez <pjoyez> | ||
Submitted: | Sun 20 Nov 2016 01:21:24 PM UTC | ||
Category: | Qt port | Priority: | 7 - High |
Item Group: | Error | Status: | Fixed |
Privacy: | Public | Assigned to: | mgubi |
Originator Name: | Open/Closed: | Closed | |
Release: | None | Release: | |
Fixed Release: | None | Fixed Release: | |
Keywords: |
Jump to the original submission
Thu 04 Mar 2021 09:14:03 PM UTC, comment #23: |
Joris van der Hoeven <vdhoeven> |
Mon 13 Apr 2020 10:37:57 PM UTC, comment #22: Fixed in 12772 |
Massimiliano Gubinelli <mgubi> |
Mon 13 Apr 2020 07:42:35 PM UTC, comment #21: Good. It seems fine to me. I'm committing and close the bug.
|
Massimiliano Gubinelli <mgubi> |
Mon 13 Apr 2020 07:28:36 PM UTC, comment #20: Hey Max, thanks to you I learned about using templates today! Good way to take profit of confinement :)
|
Philippe Joyez <pjoyez> |
Mon 13 Apr 2020 02:10:54 PM UTC, comment #19: Philippe, sorry for bother again. This solution is ok but not perfect because that code has to be #ifdef-fed only when QTTEXMACS is used, otherwise will give a problem.
|
Massimiliano Gubinelli <mgubi> |
Mon 13 Apr 2020 01:50:15 PM UTC, comment #18: Yes, you are right, it works and it is much more consistent.
|
Philippe Joyez <pjoyez> |
Mon 13 Apr 2020 12:33:10 PM UTC, comment #17: Is ok, but I do not understand why do not work. Can you try to move the declaration
|
Massimiliano Gubinelli <mgubi> |
Mon 13 Apr 2020 12:20:45 PM UTC, comment #16: Nope, 12769 still did not do it. It took my chance to further adjust it in Rev 12770. Check if that's ok for you. |
Philippe Joyez <pjoyez> |
Sun 12 Apr 2020 10:53:17 PM UTC, comment #15: Is my change that does not make sense. There is a generic version of tm_delete defined in fast_alloc.hpp and it will be used by the ABSTRACT_NULL macro, because I defined the specialised version after. So, as you correctly remark, the specialised version has to be declared before ABSTRACT_NULL(qt_widget). Rev 12769 contains a change which should solve the problem without introducing inline functions. Can you try it? Thanks. |
Massimiliano Gubinelli <mgubi> |
Sun 12 Apr 2020 10:37:46 PM UTC, comment #14: I apologize Max, I realize I did not specify where I added the code and that makes a difference:
|
Philippe Joyez <pjoyez> |
Sun 12 Apr 2020 12:34:16 PM UTC, comment #13: Philippe, should be fixed in rev 12766. Can you check and close the bug if is ok? Thanks. |
Massimiliano Gubinelli <mgubi> |
Sun 12 Apr 2020 09:34:43 AM UTC, comment #12: Great. I will try a cleaner solution: getting rid of qt_widget altogether. It should work the same. I let you know when I've committed it. |
Massimiliano Gubinelli <mgubi> |
Sun 12 Apr 2020 09:09:14 AM UTC, comment #11: Hi Max,
|
Philippe Joyez <pjoyez> |
Sat 11 Apr 2020 01:56:07 PM UTC, comment #10: I was able to make the test code work but i cannot trigger the problem on Mac. Maybe this problem is similar to others we have with tm_delete. You could try to add a function like this
|
Massimiliano Gubinelli <mgubi> |
Sat 11 Apr 2020 01:29:28 PM UTC, comment #9: The test case does not work anymore for me. TeXmacs complains of the following:
|
Massimiliano Gubinelli <mgubi> |
Sat 11 Apr 2020 01:13:04 PM UTC, comment #8: This bug is still present in rev. 12761, compiled with qt5 (and probably with qt4 too; I did not check) in linux. The crash still occurs when a scheme script calls safely-kill-window.
|
Philippe Joyez <pjoyez> |
Wed 07 Aug 2019 05:38:52 PM UTC, comment #7: Reopening because rev 11157 did not fix this, at least not in all distributions (unlike I though earlier).
|
Philippe Joyez <pjoyez> |
Tue 21 Aug 2018 10:55:50 PM UTC, comment #6: This seems to have been fixed by rev 11157. Closing. |
Philippe Joyez <pjoyez> |
Tue 06 Feb 2018 08:49:21 AM UTC, comment #5: I'm trying to reproduce this bug but on my mac (with current svn and qt 4.8.7) it seems I cannot trigger the crash. Can somebody confirm that the crash is still present? |
Massimiliano Gubinelli <mgubi> |
Fri 03 Nov 2017 10:20:43 PM UTC, comment #4: the previous "fix" is not working in ubuntu 17.10; the crash still occurs... |
Philippe Joyez <pjoyez> |
Fri 03 Nov 2017 11:15:14 AM UTC, comment #3: Until now I was avoiding the bug for myself by reverting most changes Max had made after 10544...
|
Philippe Joyez <pjoyez> |
Fri 03 Nov 2017 10:56:13 AM UTC, comment #2: here are two file to reproduce the issue (still occurring and also in ubuntu 17.10)
|
Philippe Joyez <pjoyez> |
Thu 22 Jun 2017 09:14:19 PM UTC, comment #1: Massimiliano?
|
Joris van der Hoeven <vdhoeven> |
Sun 20 Nov 2016 01:21:24 PM UTC, original submission:
I have recently set up a new machine with ubuntu 16.04 and found that one of my scheme scripts that automatically open and close an extra window (and which works perfectly in ubuntu 14.04, debian, and windows) would systematically crash when closing the window, throwing a "free() invalid pointer" and SIGABRT.
|
Philippe Joyez <pjoyez> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 20 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2021-03-04 | vdhoeven | Open/Closed | Open | Closed | |
2020-04-13 | mgubi | Status | Ready For Test | Fixed | |
2020-04-13 | pjoyez | Attached File | - | Added another_fix_for_49655.patch, #48831 | |
2020-04-12 | mgubi | Status | Confirmed | Ready For Test | |
2020-04-11 | pjoyez | Summary | recent changes in Qt plugin cause "free() invalid pointer" crash in ubuntu 16.04 | safely-kill-window with qt may causes corruption and crash when fast_alloc is used | |
2020-04-11 | pjoyez | Attached File | - | Added backtrace, #48813 | |
2019-10-19 | vdhoeven | Priority | 5 - Normal | 7 - High | |
Status | None | Confirmed | |||
2019-08-07 | pjoyez | Status | Fixed | None | |
Open/Closed | Closed | Open | |||
2018-08-21 | pjoyez | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2018-02-06 | mgubi | Originator Name | Joyez | ||
2018-02-06 | mgubi | Priority | 9 - Immediate | 5 - Normal | |
Originator Name | Joyez | ||||
2018-02-05 | mgubi | Priority | 5 - Normal | 9 - Immediate | |
2017-11-03 | pjoyez | Attached File | - | Added place-in-my-init-texmacs.scm, #42323 | |
Attached File | - | Added simple_texmacs_connect.py, #42324 | |||
2017-06-22 | vdhoeven | Assigned to | None | mgubi | |
2016-11-20 | pjoyez | Attached File | - | Added gdb_output, #39029 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Seems to be fine now.
Please re-open if someone again experiences a problem.