bugmake - Bugs: bug #20006, Regression between 3.80 and 3.81

 
 

bug #20006: Regression between 3.80 and 3.81

Submitter:  Icarus Sparry <icarus>
Submitted:  Wed 30 May 2007 12:20:51 AM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Duplicate Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Component Version:  3.81 Operating System:  Any
Fixed Release:  None Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 13 Jun 2009 10:22:17 PM UTC, comment #2: 

This is a duplicate of bug #17752  --verified fixed in the latest CVS as a result of that fix.

Paul D. Smith <psmith>
Group administrator
Fri 04 Apr 2008 11:25:32 AM UTC, comment #1: 

We just stumbled over the same bug when upgrading from 3.80 to 3.81. As additional data point, I verified that reverting the change in implicit.c from 1.40 to 1.41 in a version freshly checked out from CVS fixes it (in our project -- and don't ask me why ;). This is the change I made:

aragon: .../tools/make > cvs diff -u
Index: implicit.c
===================================================================
RCS file: /sources/make/make/implicit.c,v
retrieving revision 1.66
diff -u -r1.66 implicit.c
--- implicit.c  4 Jul 2007 19:35:19 -0000       1.66
+++ implicit.c  4 Apr 2008 11:18:38 -0000
@@ -678,7 +678,7 @@
                  so it might actually exist.  */
 
               /* @@ dep->changed check is disabled. */
-              if (((f = lookup_file (name)) != 0 && f->is_target)
+              if (lookup_file (name) != 0
                   /*|| ((!dep->changed || check_lastslash) && */
                   || file_exists_p (name))
                 continue;

Ben Franksen <bgwf>
Wed 30 May 2007 12:20:51 AM UTC, original submission:  

Given a directory containing only a file T.in (any contents) and a Makefile with the following contents

%.out: %; touch $@
%: %.in;touch $@
.PHONY: good bad
good: T T.out
bad: T.out T

then running "make -r bad" with GNU make 3.81 gives

make: * No rule to make target `T.out', needed by `bad'.  Stop.

On the other had using 3.80, it produces the expected results.
touch T
touch T.out

The change from version 1.40 to 1.41 of implicit.c which has the following log message
revision 1.41
date: 2004-09-21 13:23:12 -0700;  author: bosk;  state: Exp;  lines: +3 -1;
Fixed bug in implicit rule prerequisite evaluation code. Added test.

is at least partly responsible for the regression. Making just this change causes the modified make to give the error message. However both 3.80 and 3.81 manage to build the 'good' target, but the modified one gives

touch T
make+: * No rule to make target `T.out', needed by `good'.  Stop.


Icarus Sparry <icarus>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by bgwf (Posted a comment)
  • -email is unavailable- added by icarus (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-06-13 psmith StatusNone Duplicate
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code