bugGnash - The GNU Flash player - Bugs: bug #39482, GIFLIB-5.0 API change

 
 

bug #39482: GIFLIB-5.0 API change

Submitter:  OBATA Akio <obache>
Submitted:  Sun 14 Jul 2013 02:31:05 AM UTC
   
 
Category:  build Severity:  3 - Normal
Release:  0.8.10 Status:  Fixed
Privacy:  Public Assigned to:  strk
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 15 Jul 2013 07:24:48 AM UTC, comment #2: 

Preprocessor seems to be happy with that macro not being defined, so am I. Patch pushed: http://git.savannah.gnu.org/gitweb/?p=gnash.git;a=commitdiff;h=cc22f2d

Sandro Santilli <strk>
Group Member
Mon 15 Jul 2013 07:09:32 AM UTC, comment #1: 

As of giflib-4.1.6 there's no GIFLIB_MAJOR macro defined in headers.

Sandro Santilli <strk>
Group Member
Sun 14 Jul 2013 02:31:05 AM UTC, original submission:  

GIFLIB-5.0 introduce some API change:
 http://giflib.sourceforge.net/gif_lib.html#compatibility
It affect to Gnash, so it should be changed.
Following is a proposed patch to resolve the issue.

--- libbase/GnashImageGif.cpp.orig      2012-01-19 19:17:48.000000000 +0000
+++ libbase/GnashImageGif.cpp
@@ -269,7 +269,11 @@ GifInput::processRecord(GifRecordType re
 void
 GifInput::read()
 {
+#if GIFLIB_MAJOR >= 5
+    _gif = DGifOpen(_inStream.get(), &readData, NULL);
+#else
     _gif = DGifOpen(_inStream.get(), &readData);
+#endif

     GifRecordType record;


OBATA Akio <obache>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by obache (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-07-15 strk StatusNone Fixed
        Assigned toNone strk
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code