bugphpGroupWare - Bugs: bug #8975, bug in building sql-query (Better...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #8975: bug in building sql-query (Better one whitespace too much than too few...)

Submitter:  Matthias Leonhardt <mleonhardt>
Submitted:  Sun 16 May 2004 09:14:30 AM UTC
   
 
Category:  calendar Item Group:  0.9.16.000 release
Severity:  3 - Normal Priority:  5 - Normal
Status:  Fixed Privacy:  Public
Assigned to:  skwashd Open/Closed:  Closed
Component Version:  SVN Operating System:  GNU/Linux - Debian
Reproducibility:  None Planned Release:  None
Fixed Release: 

Sun 16 May 2004 11:07:06 AM UTC, comment #1: 

Fixed in 16 cvs.  The patch in its provided form was not usable.

Dave Hall <skwashd>
Group administrator
Sun 16 May 2004 09:14:30 AM UTC, original submission:  

Index: class.socalendar_sql.inc.php
===================================================================
RCS file: /cvsroot/phpgroupware/calendar/inc/class.socalendar_sql.inc.php,v
retrieving revision 1.28.2.4.2.8
diff -u -r1.28.2.4.2.8 class.socalendar_sql.inc.php
--- class.socalendar_sql.inc.php 12 Sep 2003 02:16:22 -0000
1.28.2.4.2.8
+++ class.socalendar_sql.inc.php 14 May 2004 15:14:56 -0000
@@ -827,7 +826,7 @@
  $lastmod = intval($lastmod);
  $repeats = (bool) $repeats;
 
- $user_where = " AND phpgw_cal_user.cal_login = $this->user";
+ $user_where = " AND phpgw_cal_user.cal_login = $this->user ";
 
  $member_groups =
$GLOBALS['phpgw']->accounts->membership($this->user);
  @reset($member_groups);
@@ -846,9 +845,9 @@
 
  if($lastmod > 0)
  {
- $wheremod = "AND mdatetime = $lastmod";
+ $wheremod = " AND mdatetime > $lastmod";
  }
-
+
  $order_by = ' ORDER BY phpgw_cal.cal_id ASC';
  if($this->debug)
  {

Matthias Leonhardt <mleonhardt>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-05-16 skwashd StatusNone Fixed
    Assigned toalexbsa skwashd
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code