bugPSPP - Bugs: bug #16189, libplot check doesn't check for...

 
 

bug #16189: libplot check doesn't check for other necessary libraries

Submitted by:  Ben Pfaff <blp>
Submitted on:  Sun 26 Mar 2006 05:29:22 AM UTC  
 
Category:  Compilation/Portability Severity:  5 - Average
Status:  Fixed Assigned to:  Jason H Stover <jstover>
Open/Closed:  Closed Release:  Before 0.6.0
Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 05 Aug 2007 10:15:46 PM UTC, comment #5: 

>Yes, that worked.


Thanks.

>What kind of setup did you have in mind?
>I might be able to install XWindows on a
>BSD machine and test this.


If X support is enabled in libplot, then on some machines this means that the linker needs to be told to link against the X libraries as well as libplot.  (This isn't true on GNU/Linux, where the linker does this, if necessary, automatically.)  This patch is intended to take care of this by trying to link against typical X libraries if libplot by itself doesn't work.

I don't think it's worthwhile for you to spend a bunch of time trying to reproduce the problem.  As long as it doesn't actively hurt any machines--and your testing shows that it probably won't--it's a step in the right direction.  If it doesn't fully solve the problem for someone, then we'll get a bug report.

I checked this in. 

Thanks again!

Ben Pfaff <blp>
Project Administrator
Sun 05 Aug 2007 10:00:24 PM UTC, comment #4: 

Yes, that worked.

What kind of setup did you have in mind?
I might be able to install XWindows on a
BSD machine and test this.

Jason H Stover <jstover>
Project MemberIn charge of this item.
Fri 03 Aug 2007 09:30:21 PM UTC, comment #3: 

>The BSD machine I work on already has libplot, but not libXaw and
>the others mentioned below.
>
>Before applying the patch, I could run ./configure --without-gui,
>and the check for libplot passed.


Hmm, this isn't the kind of machine configuration for which the check was intended.  But it should still work there.

>autoheader: Use AC_DEFINE([HAVE_LIBPLOT], [], [Description])


Oops.  Obviously I didn't test this as well as I should have.

I'm attaching an updated (and better tested) check.  The only
substantive change from the previous one is this:

-    AC_DEFINE(HAVE_LIBPLOT)
+    AC_DEFINE(HAVE_LIBPLOT, 1,
+              [Define to 1 if you have the `libplot' library (-lplot).])

(file #13577)

Ben Pfaff <blp>
Project Administrator
Fri 03 Aug 2007 07:13:13 PM UTC, comment #2: 

The BSD machine I work on already has libplot, but not libXaw and the others mentioned below.

Before applying the patch, I could run ./configure --without-gui, and the check for libplot passed.

After applying the patch, make -f Smake told me it can't find HAVE_LIBPLOT:

aclocal -I m4 -I gl/m4
autoconf
autoheader
autoheader: warning: missing template: HAVE_LIBPLOT
autoheader: Use AC_DEFINE([HAVE_LIBPLOT], [], [Description])

      • Error code 1

I do not have XWindows installed on the BSD machine, so I have to use --without-gui.

Jason H Stover <jstover>
Project MemberIn charge of this item.
Thu 26 Jul 2007 04:40:32 AM UTC, comment #1: 

Jason: does the attached patch fix the problem for you under OpenBSD?

(file #13474)

Ben Pfaff <blp>
Project Administrator
Sun 26 Mar 2006 05:29:22 AM UTC, original submission:  

The libplot check in configure.ac will fail if other libraries need to be linked in to make libplot work.  For example, on OpenBSD it appears that libXaw, libXt, libXext, and libX11 must also be linked.

There is a libplot check at https://subversion.imagemagick.org/subversion/wmf/trunk/acinclude.m4 that appears to do something closer to what we should be doing, but it will need some adaptation.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #13577:  libplot-check.patch added by blp (1KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jstover (Posted a comment)
  • -email is unavailable- added by blp (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-08-05 blp StatusReady for Test/Review => Fixed
        Open/ClosedOpen => Closed
    2007-08-03 blp Attached File#13474 => Removed
    2007-08-03 blp Attached File- => Added libplot-check.patch, #13577
    2007-07-26 blp Attached File- => Added libplot-check.patch, #13474
        StatusNone => Ready for Test/Review
        Assigned toNone => jstover
    2006-07-31 blp ReleaseNone => Before 0.6.0

    Back to the top


    Powered by Savane 3.5