bugPSPP - Bugs: bug #16173, should support non-GNU make

 
 

bug #16173: should support non-GNU make

Submitted by:  Ben Pfaff <blp>
Submitted on:  Thu 23 Mar 2006 05:02:33 PM UTC  
 
Category:  Compilation/Portability Severity:  5 - Average
Status:  Fixed Assigned to:  Jason H Stover <jstover>
Open/Closed:  Closed Release:  None
Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Jul 2006 04:39:19 AM UTC, comment #4: 

AC_CONFIG_AUX_DIR wont help in this instance I don't think.  This issue will only become a problem if we move to a version of automake which has different internal symbols.  So I'm not going to worry about this now.

I've changed "mkdir -p" to "$(top_srcdir)/mkinstalldirs".

I've updated README.

I've also deleted psppire-case-array.* and made sure that make distcheck now passes.

We believe that this problem is fixed in a change recently
checked into the CVS respository.  If you discover that the bug
has not been fixed, please re-open the bug.

Thank you for your help in improving PSPP.

John Darrington <jmd>
Project Administrator
Fri 14 Jul 2006 03:28:45 PM UTC, comment #3: 

A few comments:

The autoconf manual says:

>`mkdir'
>     None of `mkdir''s options are portable.  Instead of `mkdir -p
>     FILENAME', you should use use `AS_MKDIR_P(FILENAME)' (*note
>     Programming in M4sh::).


although it's not the right syntax to use in a Makefile.  There's another use of mkdir -p later in the patch.

+# Kludge to get around automake deficiency.
+am__TEXINFO_TEX_DIR=./doc

Should we be using AC_CONFIG_AUX_DIR(build-aux) and put texinfo.tex, among other files, in build-aux/?  (Would that solve the problem?)

Otherwise looks good to me, as long as it works (and it sounds like it does).

When this is committed, the README should be updated to drop the requirement for GNU make.

Ben Pfaff <blp>
Project Administrator
Fri 14 Jul 2006 02:51:35 PM UTC, comment #2: 

works on OBSD 3.9 + x86 with BSD make.

Jason H Stover <jstover>
Project MemberIn charge of this item.
Fri 14 Jul 2006 04:44:27 AM UTC, comment #1: 

The attached patch seems to work using freebsd-make on GNU/Linux.

Thanks to  Stepan Kasal for helping to solve this problem.

John Darrington <jmd>
Project Administrator
Thu 23 Mar 2006 05:02:33 PM UTC, original submission:  

Our current makefiles require GNU make.  We should support other make implementations as well.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #10344:  automake.patch added by jmd (212KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-07-15 jmd StatusWorks For Me => Fixed
    Open/ClosedOpen => Closed
2006-07-14 jstover StatusReady for Test/Review => Works For Me
2006-07-14 jmd StatusNone => Ready for Test/Review
    Assigned toNone => jstover
    Attached File- => Added automake.patch, #10344

Back to the top


Powered by Savane 3.5