bugDotGNU Portable.NET - Bugs: bug #14858, BooleanAnd and BooleanOr swapped...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14858: BooleanAnd and BooleanOr swapped in CodeDom Generators

Submitter:  None
Submitted:  Tue 25 Oct 2005 04:34:31 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Tue 25 Oct 2005 11:56:21 PM UTC, comment #1: 

fixed in cvs

Deryk Robosson <drobosson>
Group Member
Tue 25 Oct 2005 04:34:31 PM UTC, original submission:  

The CodeGeneration for CSharp and VB.NET has the BooleanOr and BooleanAnd value swapped. Specifically the function OutputOperator(CodeBinaryOperatorType op) in both CodeGenerator.cs and VBCodeCompiler.cs.

The original code (as of .72) in CodeGenerator.cs is:

case CodeBinaryOperatorType.BooleanOr:
oper = "&&"; break;
case CodeBinaryOperatorType.BooleanAnd:
oper = "||"; break;

and in VBCodeCompiler.cd is:
case CodeBinaryOperatorType.BooleanOr:
oper = "AndAlso"; break;
case CodeBinaryOperatorType.BooleanAnd:
oper = "OrElse"; break;

CLEARLY these are incorrect.

You can compare the CodeGenerator.cs to the version in the ROTOR project provided by Microsoft  at:
http://dotnet.di.unipi.it/Content/sscli/docs/doxygen/fx/bcl/codegenerator_8cs-source.html
which has the correct values.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-10-25 drobosson StatusNone Fixed
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code