bugPSPP - Bugs: bug #13054, Infinite loop in LIST command

 
 

bug #13054: Infinite loop in LIST command

Submitter:  John Darrington <jmd>
Submitted:  Wed 11 May 2005 01:21:37 AM UTC
   
 
Category:  Other Severity:  9 - Blocker
Status:  Fixed Assigned to:  blp
Open/Closed:  Closed Release:  0.4.0
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 17 May 2005 05:48:43 AM UTC, comment #7: 

A fix has been checked in to the CVS repository

Ben Pfaff <blp>
Group administrator
Mon 16 May 2005 07:39:56 AM UTC, comment #6: 

Okay, I've fixed the problem with the survey_data.sav file.

The problems mentioned in comment #5 are slightly different and I will fix them in another check-in some other day.

Ben Pfaff <blp>
Group administrator
Sat 14 May 2005 09:06:41 AM UTC, comment #5: 

This problem is probably related.

There are another couple of .SAV files at http://www.ibiblio.org/laslave/downloads.php

(these have been created with spss v9.0)

Loading these and listing them causes an assertion at
data-out.c:65

John Darrington <jmd>
Group administrator
Sat 14 May 2005 07:13:26 AM UTC, comment #4: 

Hmm, this is actually pretty nasty.

I've got a replacement for the output conversion code for F that should fix the problem and be much better in other ways (possibly faster).  Unfortunately, I'm going away for the weekend so it won't get tested and checked in until Monday or so.

Ben Pfaff <blp>
Group administrator
Wed 11 May 2005 03:39:44 AM UTC, comment #3: 

Check-in apparently only fixed the brief test case, not the long one.  Will take another look later.

Ben Pfaff <blp>
Group administrator
Wed 11 May 2005 03:09:35 AM UTC, comment #2: 

I've fixed this problem but I don't think the current code is very careful in this area.  Ideally we should write some good tests.  I've added some assertions to help ferret out any more examples.

Ben Pfaff <blp>
Group administrator
Wed 11 May 2005 02:09:52 AM UTC, comment #1: 

The problem can be more easily demonstrated with this simple code:

DATA LIST LIST /day (F2.1).
BEGIN DATA
16
6
END DATA.

LIST.

John Darrington <jmd>
Group administrator
Wed 11 May 2005 01:21:37 AM UTC, original submission:  

There's a report at
http://www.chronovault.net/websites/tobi/researchID/results
Which gives a link to 2 spss system files.

I downloaded each of them, and did
GET /FILE='survey_data...sav'.
LIST.

The list command gets stuck in an infinite loop.

Brief investigation showed the offending loop is at data-out.c:1235
which says:
  /* Normally we only go through the loop once; occasionally twice.
     Three times or more indicates a very serious bug somewhere. */
  for (;;)
    {
    .
    .
    .
    }

In view of this comment, I'm marking this problem as Severity:9


John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 8 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-05-17 blp StatusIn Progress Fixed
    Open/ClosedOpen Closed
2005-05-11 blp StatusFixed In Progress
    Open/ClosedClosed Open
    ReleaseNone 0.4.0
2005-05-11 blp StatusNone Fixed
    Assigned toNone blp
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code