bugPSPP - Bugs: bug #11612, q2c documentation does not agree...

 
 

bug #11612: q2c documentation does not agree with code

Submitted by:  John Darrington <jmd>
Submitted on:  Sun 16 Jan 2005 12:06:12 PM UTC  
 
Category:  Syntax Parser Severity:  3 - Ordinary
Status:  Fixed Assigned to:  Ben Pfaff <blp>
Open/Closed:  Closed Release:  Before 0.6.0
Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 05 Jul 2006 05:15:07 AM UTC, comment #4: 

> I'm not sure that it makes any sense to have a '+' on the /MISSING
> subcommands.


Good point.  With that change, I checked this in.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Wed 05 Jul 2006 03:56:57 AM UTC, comment #3: 

I'm not sure that it makes any sense to have a '+' on the /MISSING subcommands.

John Darrington <jmd>
Project Administrator
Wed 05 Jul 2006 03:00:23 AM UTC, comment #2: 

Any comments?

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 02 Jul 2006 12:45:26 AM UTC, comment #1: 

I chose to change the code to agree with the docs.  The attached patch modifies src/*.q to do the right thing (IMO).

Review?

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 16 Jan 2005 12:06:12 PM UTC, original submission:  

doc/q2c.texi states "A plus sign (+) is used to indicate that a subcommand can appear more than once".  However src/q2c.c is coded such that the opposite is true.  As a result, many subcommands which should be available more than once are not, and vici-versa.

We need to make doc/q2c.texi and src/q2c.c agree (one way or the other) and then audit src/*.q to make sure that subcommands have the '+' prefix or not as appropriate.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #10288:  q2c-consistency.patch added by blp (11KiB - application/octet-stream - proposed fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-07-05 blp StatusReady for Test/Review => Fixed
    Assigned toNone => blp
    Open/ClosedOpen => Closed
2006-07-02 blp StatusNone => Ready for Test/Review
    Attached File- => Added q2c-consistency.patch, #10288
2005-05-07 blp ReleaseNone => Before 0.6.0

Back to the top


Powered by Savane 3.5