phpGroupWare - Bugs: bug #10482, Deleteing User in LDAP won\'t...
You are not allowed to post comments on this tracker with your current authentication level.
bug #10482: Deleteing User in LDAP won\'t remove it from its groups
Submitter: | Olivier Berger <oberger> | ||
Submitted: | Thu 23 Sep 2004 03:59:39 PM UTC | ||
Category: | API - Admin | Item Group: | 0.9.16.003 |
Severity: | 3 - Normal | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | fipsfuchs | Open/Closed: | Open |
Component Version: | SVN | Operating System: | GNU/Linux - Debian |
Reproducibility: | Every Time | Planned Release: | None |
Fixed Release: |
Jump to the original submission
Fri 01 Oct 2004 02:05:15 PM UTC, comment #8: |
Philipp Kamps <fipsfuchs> |
Fri 24 Sep 2004 03:02:09 PM UTC, comment #7: The new patch here, seems to be ok for both deleting accounts (and removing menmberUID) and modifying the dn of an account.
|
Caeies <Caeies> |
Fri 24 Sep 2004 11:40:24 AM UTC, comment #6: Ok, In fact this is not the real problem,
|
Caeies <Caeies> |
Fri 24 Sep 2004 08:51:59 AM UTC, comment #5: Hum, I found a nasty problem when renaming dn ... the function id2name use a cache system which is not updated when modifying the dn, this kill the add_account2Group and delete_account4Group, ...
|
Caeies <Caeies> |
Fri 24 Sep 2004 07:29:48 AM UTC, comment #4: please don't have a deeper look to the rest of the API. You won't be able to sleep anymore ;-)
|
Philipp Kamps <fipsfuchs> |
Fri 24 Sep 2004 07:12:10 AM UTC, comment #3: By the way, I didn't sleep well this night, and think about this bug.
|
Caeies <Caeies> |
Thu 23 Sep 2004 05:51:48 PM UTC, comment #2: I'll have a look tomorrow and give you feedback - thanks for asking me. |
Philipp Kamps <fipsfuchs> |
Thu 23 Sep 2004 04:05:13 PM UTC, comment #1: Bug acknowledged
|
Caeies <Caeies> |
Thu 23 Sep 2004 03:59:39 PM UTC, original submission:
When using LDAP to store users and groups, the user deletion in admin/user won't remove the User from its groups : user gets deleted in LDAP but the group's memberUid is still there in the Group in LDAP. |
Olivier Berger <oberger> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2004-09-24 | Caeies | Summary | Deleteing User in LDAP won't remove it from its groups | Deleteing User in LDAP won\'t remove it from its groups | |
Attached File | - | Added patch_manage_groups_ldap.patch, #1704 | |||
2004-09-23 | Caeies | Assigned to | None | fipsfuchs | |
Attached File | - | Added patch_delete_account_ldap.diff, #1697 |
Powered by Savane 3.13-caa5.
Corresponding source code
hi caeies,
patch is great.
some little modifications - just some tiny remarks - don't take them too serious and add them only if you really want:
- I dont understand this comment: "//get the groups this dn in it's own groups"
- "if (($olddn=$oldEntry['dn']) != $dn)" no need to declare $olddn - you only need this var once some lines below.
- "$groups = $this->membership($account_info['account_id']);" instead of using $account_info['account_id'] can we use a value from the $oldEntry array?
- plz add method description for "function getUIDfromDN($dn)"
- in case you have a group with just one member - are you sure that this member can be deleted? The program logic is in this if statement:
"if (is_array($groupEntry['memberuid']))"
As I said before - these remarks are kids stuff - if you want me to change the patch Im happy to do it.
Otherwise I think it is a clean and nice implementation for this feature.