GNU nano - Bugs: bug #65369, nano crashes after searching in...
You are not allowed to post comments on this tracker with your current authentication level.
bug #65369: nano crashes after searching in help during a regex replace session
Submitter: | correctmost <correctmost> | ||
Submitted: | Mon 26 Feb 2024 09:41:29 AM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Open |
Mon 26 Feb 2024 12:34:40 PM UTC, comment #2: |
Benno Schulenberg <bens> |
Mon 26 Feb 2024 12:07:51 PM UTC, comment #1: Thanks for reporting. The crash is caused by the Search-in-help freeing the compiled regex before the replacement session is going to use it. But when searching in a help text, regex and case and backward are not used, so... when 'inhelp' is set, tidy_up_after_search() should not free anything (nor do anything else).
|
Benno Schulenberg <bens> |
Mon 26 Feb 2024 09:41:29 AM UTC, original submission:
Steps to reproduce:
|
correctmost <correctmost> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2024-02-26 | bens | Status | Confirmed | Fixed | |
2024-02-26 | bens | Status | None | Confirmed | |
Assigned to | None | bens | |||
Summary | Crash after performing regex search in help during replace session | nano crashes after searching in help during a regex replace session |
Powered by Savane 3.13-02a9.
Corresponding source code
Fixed in git, commit ee1a1306, by returning immediately from tidy_up_after_search() when 'inhelp' is set. (This should be fine, because the mark cannot be set in help texts either, and the syntax for help texts does not -- and should not -- use multiline regexes, so 'recook' and 'perturbed' are irrelevant too.)