bugXnee - Bugs: bug #58810, Do not unintentionally declare...

 
 

bug #58810: Do not unintentionally declare enum variables (unbreak the build with GCC 10)

Submitted by:  Peter Pentchev <ppentchev>
Submitted on:  Thu 23 Jul 2020 07:15:39 AM UTC
 
Category:  libxnee Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Thu 23 Jul 2020 07:15:39 AM UTC, original submission:  

Hi,

First of all, thanks for writing and maintaining the Xnee suite!

What do you think about the attached patch that corrects the declaration of enumerated types so that they do not accidentally define variables of the corresponding type?

To be honest, I was not sure whether the double naming was because of an intention to declare typedefs for all these enums or out of routine. If the intention was to create typedefs, I can rework my patch to do that instead; however, since none of these types are actually used, I was not certain which way to go and chose the one with the least number of declarations.

Thanks again, and keep up the great work!

G'luck,
Peter

Peter Pentchev <ppentchev>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49534:  enum-decl.patch added by ppentchev (4KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ppentchev (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-23 ppentchev Attached File- => Added enum-decl.patch, #49534

    Back to the top


    Powered by Savane 3.9