bugiGNUit - Bugs: bug #57975, Proposal: Only search cards in the...

 
 

bug #57975: Proposal: Only search cards in the selected category

Submitter:  Dennis Nezic <dennisne>
Submitted:  Mon 09 Mar 2020 04:13:17 AM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Thu 09 Dec 2021 09:58:47 PM UTC, comment #2: 

Here's an updated version of this patch that searches the whole deck (the original method) if there is no selected category.

But it's incomplete, so I'll close the issue for now. I also don't need the feature as much now that I split apart my decks.

If it's something that people want, it should be done better, similar to the "Use regular expressions" and "Match case" Find options (eg. "Search only in selected category"), with a remembered gconf preference maybe.

(We would also want a better way for dialog-find.c to have access to app-window.c's last_selected_category ... maybe it could be passed via the dialog_find() function.)

(file #52472)

Dennis Nezic <dennisne>
Mon 09 Mar 2020 12:08:35 PM UTC, comment #1: 

Btw, I chose to use this clunky gtk_tree_view_get_selection method because other more clean looking ways such as:

 d->last_selected_category
 file_get_current_category (File *f)
 file_current_category_is_search(f)

only worked once after a category was selected, but not after a search was performed.

Dennis Nezic <dennisne>
Mon 09 Mar 2020 04:13:17 AM UTC, original submission:  

Currently every card is searched, in all categories. This patch only searches in the selected category. Perhaps there should be a menu option/toggle for this.

Dennis Nezic <dennisne>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52472:  5onlysearchselcat2.patch added by dennisne (1KiB - text/x-patch - updated but incomplete)
file #48563:  5onlysearchselcat.patch added by dennisne (962B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dennisne (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-09 dennisne Attached File- Added 5onlysearchselcat2.patch, #52472
    2020-03-09 dennisne Attached File- Added 5onlysearchselcat.patch, #48563

    Back to the top


    Powered by Savane 3.9