bugiGNUit - Bugs: bug #57443, Proposal: Allow cards to be added...

 
 

bug #57443: Proposal: Allow cards to be added after searches

Submitter:  Dennis Nezic <dennisne>
Submitted:  Wed 18 Dec 2019 08:43:16 PM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Fri 10 Dec 2021 02:43:37 AM UTC, comment #2: 

A slightly cleaner version 3 of this patch, taking advantage of file_current_category_is_special()

(file #52477)

Dennis Nezic <dennisne>
Thu 09 Dec 2021 09:38:57 PM UTC, comment #1: 

Here's an updated version of this patch, since the original one caused a segfault in cb_m_add_card() when d->last_selected_category was NULL, which can happen if a user starts without a visible category pane. In such cases, we'll add cards to the first category in the deck.

(file #52471)

Dennis Nezic <dennisne>
Wed 18 Dec 2019 08:43:16 PM UTC, original submission:  

Currently the add-card function is disabled after a search. This will enable it and set the current category to be the last_selected_category, without requiring users to manually click on a category first.

Dennis Nezic <dennisne>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52582:  3allowaddfromspecialcategories4.patch added by dennisne (2KiB - text/x-patch - fixed typo in patch)
file #52477:  3allowaddfromspecialcategories3.patch added by dennisne (2KiB - text/x-patch - slightly cleaner code)
file #52471:  3allowaddfromspecialcategories2.patch added by dennisne (2KiB - text/x-patch - add to first category if no category is selected)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dennisne (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-29 dennisne Attached File- Added 3allowaddfromspecialcategories4.patch, #52582
    2021-12-10 dennisne Attached File- Added 3allowaddfromspecialcategories3.patch, #52477
    2021-12-09 dennisne Attached File- Added 3allowaddfromspecialcategories2.patch, #52471
    2019-12-18 dennisne Attached File- Added 3allowaddfromspecialcategories.patch, #48089

    Back to the top


    Powered by Savane 3.9