bugfindutils - Bugs: bug #56832, FAIL: tests/misc/help-version


bug #56832: FAIL: tests/misc/help-version

Submitter:  Michal Nowak <mno_hime>
Submitted:  Fri 30 Aug 2019 08:14:34 AM UTC
Category:  updatedb Severity:  3 - Normal
Item Group:  Test suite failure Status:  Working as Intended
Privacy:  Public Assigned to:  jay
Originator Name:  Open/Closed:  Closed
Release:  None Fixed Release:  None
* Mandatory Fields

Add a New Comment Rich Markup

Tue 03 Sep 2019 08:27:27 PM UTC, comment #4: 

The question is if this is a test failure (in the case the tests are run with a broken shell), or (also?) a problem which can happen in updatedb (when /bin/sh is broken).

IMO we shouldn't care too much about broken (and ancient!) shells
- as you said already (it's reasonable to expect "echo" to work") -, and only prevent the test from resulting in a FP.

Bernhard Voelker <berny>
Group administrator
Tue 03 Sep 2019 03:30:52 PM UTC, comment #3: 

My gut feeling is no, because the test should reflect whether the tool actually works.  That is, if we care about making this work on Solaris and its derivatives enough to make a code change at all, we should simply change the code so that a correctly-working shell is selected as the interpreter for updatedb.sh.  

While we could also make a point fix (e.g. use /usr/bin/echo or printf) for this problem, I think that would be less useful because it leaves unsolved a bunch of other potential problems.  For example printf has other limitations on most versions of Solaris.

Other opinions - especially contrary opinions - invited!

James Youngman <jay>
Group administrator
Tue 03 Sep 2019 06:36:59 AM UTC, comment #2: 

@James: do you think we should exempt such a system from this part of the test to avoid false positives?

Bernhard Voelker <berny>
Group administrator
Sat 31 Aug 2019 09:34:56 AM UTC, comment #1: 

The problem is that updatedb is a shell script which is run with the system's /bin/sh.   On OpenIndiana, the echo command of /bin/sh completes with status 0 when its write system call fails.

A system call trace for the failing test would have been a good diagnostic to provide with your bug report.  I attach one.

As for the bugfix, to be honest I don't think this is a bug in findutils; it's reasonable to expect "echo" to work.

James Youngman <jay>
Group administrator
Fri 30 Aug 2019 08:14:34 AM UTC, original submission:  

On OpenIndiana 2019.04 (an illumos distribution) the tests/misc/help-version test of the GNU findutils 4.7.0 fails like this:

++ env find --version
++ sed -n '1s/.* p;q'
++ echo find
++ sed 's/$//'
++ echo oldfind
++ sed 's/$//'
++ echo xargs
++ sed 's/$//'
++ echo frcode
++ sed 's/$//'
++ echo locate
++ sed 's/$//'
++ echo updatedb
++ sed 's/$//'
* updatedb: bad exit status '0' (expected 1),
  with --help or --version output redirected to /dev/full
FAIL tests/misc/help-version.sh (exit status: 1)

We run the test suite with GNU utilities (sed aet al.) taking precedence in $PATH.

We don't ship locate/updatedb from GNU findutils (we deliver those from mlocate package), so, perhaps, they are not even meant to work.

Michal Nowak <mno_hime>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #47416:  TRACE added by jay (8KiB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by berny (Posted a comment)
  • -email is unavailable- added by jay (Updated the item)
  • -email is unavailable- added by mno_hime (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-05-26 jay Open/ClosedOpen Closed
    2019-08-31 jay Attached File- Added TRACE, #47416
    2019-08-31 jay StatusNone Working as Intended
    2019-08-31 jay Assigned toNone jay

    Back to the top

    Powered by Savane 3.13-ee12.
    Corresponding source code