bugGNU nano - Bugs: bug #56564, [Request] also without...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #56564: [Request] also without --quickblank, ^K and ^U should clear the status bar

Submitter:  Benno Schulenberg <bens>
Submitted:  Fri 28 Jun 2019 11:25:46 AM UTC
   
 
Severity:  1 - Wish Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Sat 03 Aug 2019 06:44:53 PM UTC, comment #4: 

Pushed the latter patch to master, commit 4314b8de.

Benno Schulenberg <bens>
Group administrator
Thu 01 Aug 2019 11:29:11 AM UTC, comment #3: 

Attached is a version of the patch that clears the status bar for a successful ^K and ^U and <Alt+Del> and M-T, but not when using M-6 or <Ctrl+Del> or <Shift+Ctrl+Del>.  What do you think?

(file #47282)

Benno Schulenberg <bens>
Group administrator
Thu 01 Aug 2019 08:23:13 AM UTC, comment #2: 

Looking at it some more, it's not right to put wipe_statusbar() in do_cut_text(), because then it will also wipe the status bar when filtering something through an external command.  In most cases this filtering will be so quick that the user won't notice, but... if it's slow, the reassuring "Executing..." message would be wiped.  Not good.

Furthermore, I don't like it that also <Ctrl+Del> and <Shift+Ctrl+Del> wipe the status bar.  They should behave like <Del> and <Backspace> and leave the status bar alone.

Benno Schulenberg <bens>
Group administrator
Wed 31 Jul 2019 08:40:23 AM UTC, comment #1: 

Thanks for the patch.  But I don't like it that the wiping is done in is_cuttable() -- the wiping should be done after the cut or copy has been actually made, not before.  So the wiping should be done in do_cut_text().  This will also allow to reduce the number of calls from three to two.

(Just as a now-irrelevant sidenote: you forgot to add a pair of braces after the 'else' in is_cuttable() -- it worked fine, of course, but it didn't look right.)

(By the way, I didn't post this issue because I didn't know how to fix it but because I wanted to think about it, whether it is actually the right thing to do.  But seeing the new behavior, I guess it is.)

Benno Schulenberg <bens>
Group administrator
Fri 28 Jun 2019 11:25:46 AM UTC, original submission:  

Run 'src/nano --ignore +999 README' and type ^K.  See how it says "[ Nothing was cut ]".  Now type <Up> ^K.  A line is cut but the status bar still says "[ Nothing was cut ]".  This is confusing.

Expected behavior: whenever ^K or ^U (or any other cutting or pasting action) was successful, the status bar should be cleared, to prevent the impression that the lingering message refers to the last performed action.

Most actions provide feedback, so anything that was on the status bar gets overwritten, but the cutting and pasting actions are normally silent.  That any message stays on the status bar while moving around in the file (with the cursor movement keys) is less of a problem: they are non-modifying actions and could not provide any such feedback.

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by wwh (Updated the item)
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-08-26 bens Open/ClosedOpen Closed
    2019-08-03 bens StatusIn Progress Fixed
    2019-08-01 bens Attached File- Added 0001-display-blank-the-status-bar-on-a-successful-cut-or-.patch, #47282
    2019-07-31 bens StatusNone In Progress
        Assigned toNone bens
    2019-07-16 wwh Attached File- Added 0001-display-blank-status-bar-on-a-successful-cut-or-past.patch, #47220

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code