GNU nano - Bugs: bug #55620, the prompt bar mishandles...
You are not allowed to post comments on this tracker with your current authentication level.
bug #55620: the prompt bar mishandles two-column characters at the screen edge
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Thu 31 Jan 2019 10:20:11 PM UTC | ||
Severity: | 2 - Minor | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Jump to the original submission
Sun 10 Feb 2019 09:21:23 AM UTC, comment #14: |
Benno Schulenberg <bens> |
Fri 08 Feb 2019 04:55:49 PM UTC, comment #13: Please report the regression as a new bug, and crossreference it here.
|
Benno Schulenberg <bens> |
Fri 08 Feb 2019 04:00:13 AM UTC, comment #12: Check that: it affects both spotlight_softwrapped() and spotlight(), since they both call display_string() with isdata set to FALSE, just as the prompt bar does. |
David Lawrence Ramsey <dolorous> |
Fri 08 Feb 2019 03:49:54 AM UTC, comment #11: Unfortunately, with more testing, I just found one problem it causes.
|
David Lawrence Ramsey <dolorous> |
Thu 07 Feb 2019 08:00:53 PM UTC, comment #10: Fixed in git, commit 56181896. |
Benno Schulenberg <bens> |
Wed 06 Feb 2019 05:44:48 PM UTC, comment #9: After some testing, your patch does seem to work. |
David Lawrence Ramsey <dolorous> |
Wed 06 Feb 2019 02:07:38 PM UTC, comment #8: The 0001 patch does appear to fix the overflow problem, but... it introduces a small other problem (apart from the ^J/^@ diplay issue). To reproduce, run the patched version, then type:
|
Benno Schulenberg <bens> |
Wed 06 Feb 2019 12:30:43 AM UTC, comment #7: I mean, aside from the ^J/^@ display issue, the problem seems to be gone. |
David Lawrence Ramsey <dolorous> |
Tue 05 Feb 2019 05:57:53 PM UTC, comment #6: Attached new versions of the patches; 0001 and 0004 are the only changed ones. If you apply the experimental patch from bug #55638 first, and then these patches, the problem seems to be gone, at least in my testing so far. |
David Lawrence Ramsey <dolorous> |
Tue 05 Feb 2019 07:19:25 AM UTC, comment #5: Bug #55638 does seem to be related to this bug. If I apply the experimental patch from there, the behavior does improve, although it still isn't perfect. |
David Lawrence Ramsey <dolorous> |
Mon 04 Feb 2019 08:49:10 AM UTC, comment #4: Thanks. Your patch fixes the specific overflow of your reproduction recipe, but... does not fix the overflow in general. For example, follow your recipe until the two-column character has just "jumped" to the next chunk and the answer at the prompt looks like this: "<xだ". Then press <Left>, and see how "だ>" has oveflowed into the first help line.
|
Benno Schulenberg <bens> |
Thu 31 Jan 2019 10:42:26 PM UTC, comment #3: Also, Pico's status bar prompt doesn't draw scrolling characters for the prompt text if the text is exactly the width of the screen, either. |
David Lawrence Ramsey <dolorous> |
Thu 31 Jan 2019 10:35:25 PM UTC, comment #2: Check that: the second paragraph should start with
|
David Lawrence Ramsey <dolorous> |
Thu 31 Jan 2019 10:31:24 PM UTC, comment #1: The attached patches should fix this. (Only the first is the actual fix; the others are cleanups.) The existing code in draw_the_promptbar() attempts to reserve space for scrolling characters, but it does so incorrectly.
|
David Lawrence Ramsey <dolorous> |
Thu 31 Jan 2019 10:20:11 PM UTC, original submission:
Currently, in git b895402, nano behaves incorrectly when the prompt text contains multi-column characters. This can be reproduced as follows:
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 16 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2019-03-25 | bens | Open/Closed | Open | Closed | |
2019-02-07 | bens | Status | In Progress | Fixed | |
Assigned to | None | bens | |||
2019-02-06 | bens | Attached File | - | Added 0001-prompt-trim-a-double-width-character-at-the-screen-s.patch, #46191 | |
Severity | 3 - Normal | 2 - Minor | |||
Status | None | In Progress | |||
Summary | the status bar prompt mishandles multi-column characters at the screen edge | the prompt bar mishandles two-column characters at the screen edge | |||
2019-02-05 | dolorous | Attached File | - | Added 0001-prompt-fix-mishandling-of-multi-column-characters-wh.patch, #46182 | |
Attached File | - | Added 0002-tweaks-calculate-a-variable-earlier-and-reuse-it.patch, #46183 | |||
Attached File | - | Added 0003-tweaks-reuse-another-variable.patch, #46184 | |||
Attached File | - | Added 0004-tweaks-use-another-variable-instead-of-calculating-t.patch, #46185 | |||
2019-01-31 | dolorous | Attached File | - | Added 0001-prompt-fix-mishandling-of-multi-column-characters-wh.patch, #46147 | |
Attached File | - | Added 0002-tweaks-calculate-a-variable-earlier-and-reuse-it.patch, #46148 | |||
Attached File | - | Added 0003-tweaks-reuse-another-variable.patch, #46149 | |||
Attached File | - | Added 0004-tweaks-use-another-variable-instead-of-calculating-t.patch, #46150 | |||
Carbon-Copy | - | Added bens |
Powered by Savane 3.13-3230.
Corresponding source code
The regression has been reported in bug #55680.